Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builtins for type hints #162

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Use builtins for type hints #162

wants to merge 3 commits into from

Conversation

speller26
Copy link
Member

@speller26 speller26 commented Oct 10, 2023

Since we have deprecated Python 3.8.

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@speller26 speller26 requested a review from a team as a code owner October 10, 2023 23:05
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7bff44e) 100.00% compared to head (1422bb5) 100.00%.

❗ Current head 1422bb5 differs from pull request most recent head 331ac41. Consider uploading reports for the commit 331ac41 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         1398      1355   -43     
  Branches        25        25           
=========================================
- Hits          1398      1355   -43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speller26 speller26 marked this pull request as draft October 10, 2023 23:35
@@ -21,7 +21,7 @@

class PersistedJobDataFormat(str, Enum):
"""
Enum class for the the required formats.
Enum class for the required formats.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch here!

math411
math411 previously approved these changes Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants