Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation: IonQ Harmony #619

Merged
merged 8 commits into from
Sep 6, 2024
Merged

deprecation: IonQ Harmony #619

merged 8 commits into from
Sep 6, 2024

Conversation

speller26
Copy link
Member

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@speller26 speller26 requested a review from a team as a code owner September 6, 2024 05:17
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -133,11 +133,6 @@
]
Copy link
Contributor

@virajvchaudhari virajvchaudhari Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harmony appearing here: Quantum Gates supported by Harmony


Reply via ReviewNB

@@ -133,11 +133,6 @@
]
Copy link
Contributor

@virajvchaudhari virajvchaudhari Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, will need to re-run all cells.


Reply via ReviewNB

@@ -104,10 +104,10 @@
"outputs": [],
Copy link
Contributor

@virajvchaudhari virajvchaudhari Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here

{'arn:aws:braket:us-west-1::device/qpu/rigetti/Aspen-M-3': {'shots': 141, 'tasks': {'CREATED': 1}}, 'arn:aws:braket:us-east-1::device/qpu/ionq/Harmony': {'shots': 141, 'tasks': {'CREATED': 1}}}


Reply via ReviewNB

@@ -96,17 +96,17 @@
"print('\\n') \n",
Copy link
Contributor

@virajvchaudhari virajvchaudhari Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Ankaa-2 and Aria-1?.

Quantum Task Summary
{'arn:aws:braket:us-west-1::device/qpu/rigetti/Aspen-M-3': {'shots': 2000, 'tasks': {'COMPLETED': 2}}, 'arn:aws:braket:us-east-1::device/qpu/ionq/Harmony': {'shots': 1000, 'tasks': {'COMPLETED': 1}}}

Reply via ReviewNB

@@ -262,7 +262,9 @@
"outputs": [
Copy link
Contributor

@virajvchaudhari virajvchaudhari Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #5.    # device_arn = Devices.Rigetti.AspenM3

Should we be removing this as well?


Reply via ReviewNB

@@ -230,9 +230,9 @@
"outputs": [
Copy link
Contributor

@virajvchaudhari virajvchaudhari Sep 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we not replacing AspenM3 with Ankaa here?


Reply via ReviewNB

@virajvchaudhari
Copy link
Contributor

Are we also planning to replace Aspen-M3 with Ankaa-2 everywhere?

@speller26
Copy link
Member Author

Are we also planning to replace Aspen-M3 with Ankaa-2 everywhere?

That'll be another PR, as it's more involved; this one only makes changes in examples where Harmony appears.

@virajvchaudhari
Copy link
Contributor

Are we also planning to replace Aspen-M3 with Ankaa-2 everywhere?

That'll be another PR, as it's more involved; this one only makes changes in examples where Harmony appears.

Sounds good, just wanted to make sure that we don't miss out changes to any of our integ_tests as part of the arn changes for AspenM3 in this PR.

@speller26 speller26 merged commit 89b1ba3 into main Sep 6, 2024
8 checks passed
@speller26 speller26 deleted the harmony branch September 6, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants