WIP: Quantum partition function #17

AoyuQC · 2022-11-14T11:26:02Z

Issue #, if available:

Description of changes:

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I used the commit message format described in CONTRIBUTING
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

review-notebook-app · 2022-12-12T19:56:57Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

zmohammad01 · 2023-02-23T14:16:55Z

@mbeach-aws @christianbmadsen I believe this PR is just waiting for our team to review?

christianbmadsen · 2023-02-24T00:18:14Z

@mbeach-aws @christianbmadsen I believe this PR is just waiting for our team to review?

Acknowledged. We will take another look. Thanks for the nudge!

licedric · 2023-02-24T18:42:47Z

I wonder if it makes sense to describe a bit more what the functions are doing?

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

licedric · 2023-02-24T18:10:17Z

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

+    circuit = None
+
+    if function == "shor":
+        print("shor's algorithm for iccc-check hasn't been implemented!")


Suggested change

print("shor's algorithm for iccc-check hasn't been implemented!")

print("Shor's algorithm for iccc-check hasn't been implemented!")

Also do you plan to implement this function? If not you should probably remove it.

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

licedric · 2023-02-24T18:12:04Z

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

+
+
+@circuit.subroutine(register=True)
+def quantum_partition_function(


I don't think the comments in this function sufficiently describe what the function does. Could you flesh out the docstring or at least add a reference?

licedric · 2023-02-24T18:17:40Z

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

+
+def run_quantum_partition_function(
+    potts_model: dict,
+    step: str,


Is there a reason to use the step keyword here instead of putting each step as a separate function?

licedric · 2023-02-24T18:18:37Z

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

+    if step == "pre":
+        print("Classical Preprocessing to [n,k] Code")
+        Ga = potts_model["graph-model"]
+        # q = potts_model["q-state"]


What's this line?

licedric · 2023-02-24T18:19:18Z

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

+
+
+def run_quantum_partition_function(
+    potts_model: dict,


Maybe you should consider defining potts_model as an object instead. Otherwise it is hard for a user to tell what should go in here

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

licedric · 2023-02-24T18:20:42Z

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py

+            'graph-model': networkx graph to save the definition of potts model
+            'q-state': q-state of potts model
+            'qft-func': dictionary to save information for quantum fourier transform function
+                'task': braket task for quantum fourier transform


Suggested change

'task': braket task for quantum fourier transform

'task': Braket task for quantum fourier transform

speller26 · 2023-02-24T20:15:12Z

In general, the notebook needs more explanation than just the code blocks; you should be interleaving code and markdown cells, with a markdown cell before each code block explaining what is happening, with the math if applicable.

codecov-commenter · 2023-07-10T11:03:55Z

Codecov Report

Patch coverage: 48.10% and project coverage change: -3.71 ⚠️

Comparison is base (700dbbf) 100.00% compared to head (828c481) 96.29%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files

@@             Coverage Diff             @@
##              main      #17      +/-   ##
===========================================
- Coverage   100.00%   96.29%   -3.71%     
===========================================
  Files           26       28       +2     
  Lines         1028     1107      +79     
  Branches       161      197      +36     
===========================================
+ Hits          1028     1066      +38     
- Misses           0       34      +34     
- Partials         0        7       +7

Impacted Files	Coverage Δ
...m_partition_function/quantum_partition_function.py	`47.43% <47.43%> (ø)`
.../algorithms/quantum_partition_function/__init__.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

peterkomar-aws · 2024-03-29T18:14:20Z

Hello AoyuQC, This PR has had little activity; I will close it for now. You are welcome to come back and work on it and reopen it any time. You can also consider developing this work further in a sperate repo of yours and highlighting it on in Braket Algorithm library "Community repos" section, which we recently added. I hope this helps.

AoyuQC added 13 commits November 10, 2022 06:57

initial submit for quantum partition function

f0efe8f

finish step 1-3 for qpf

4d4ded4

Merge branch 'main' into quantum-partition-function

f290804

format code structure

71dd313

add 4 steps in run_{alg} func

336801c

finish 1 test case

e8d36a9

fail at local install

e2e4754

finish unit test

f7e71b6

solve format error

d887ec7

fix format

3a2dfe3

re-format again

e647efd

solve black error

7c7cc7e

rm matplotlib in src

a9956c3

mbeach-aws reviewed Nov 15, 2022

View reviewed changes

src/braket/experimental/algorithms/quantum_partition_function/quantum_partition_function.py Show resolved Hide resolved

mbeach-aws marked this pull request as draft November 15, 2022 18:33

minor (#23)

e174366

mbeach-aws marked this pull request as ready for review November 15, 2022 20:49

mbeach-aws marked this pull request as draft November 15, 2022 21:14

AoyuQC added 2 commits November 15, 2022 23:58

fix long import

d77b1b6

fix unit test issue

504eefa

AoyuQC marked this pull request as ready for review November 16, 2022 05:13

mbeach-aws requested changes Nov 16, 2022

View reviewed changes

AoyuQC added 2 commits November 17, 2022 06:26

fix doctring

5c69280

solve conflicts

752d60c

AoyuQC requested a review from mbeach-aws November 17, 2022 23:36

AoyuQC added 3 commits November 21, 2022 00:24

solve conflicts

da84261

rewrite content

18bcd8f

fix unit-test bug

b639988

mbeach-aws marked this pull request as draft November 23, 2022 14:13

AoyuQC marked this pull request as ready for review December 14, 2022 08:16

licedric requested review from a team and removed request for a team February 24, 2023 18:24

licedric reviewed Feb 24, 2023

View reviewed changes

licedric requested a review from speller26 February 24, 2023 18:43

AoyuQC added 2 commits February 27, 2023 02:51

Merge branch 'main' into quantum-partition-function

f9bb5f6

improve comments contents

94f1f4e

AoyuQC changed the title ~~Quantum partition function~~ WIP: Quantum partition function Feb 27, 2023

AoyuQC added 3 commits February 27, 2023 03:29

improve braket&potts comments

a7833e3

Merge branch 'main' into quantum-partition-function

c06a8e2

fix: formating code

828c481

peterkomar-aws closed this Mar 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Quantum partition function #17

WIP: Quantum partition function #17

AoyuQC commented Nov 14, 2022 •

edited

Loading

review-notebook-app bot commented Dec 12, 2022

zmohammad01 commented Feb 23, 2023

christianbmadsen commented Feb 24, 2023

licedric commented Feb 24, 2023

licedric Feb 24, 2023

licedric Feb 24, 2023

licedric Feb 24, 2023

licedric Feb 24, 2023

licedric Feb 24, 2023

licedric Feb 24, 2023

licedric Feb 24, 2023

speller26 commented Feb 24, 2023

codecov-commenter commented Jul 10, 2023 •

edited

Loading

peterkomar-aws commented Mar 29, 2024

	print("shor's algorithm for iccc-check hasn't been implemented!")
	print("Shor's algorithm for iccc-check hasn't been implemented!")



		@circuit.subroutine(register=True)
		def quantum_partition_function(

	'task': braket task for quantum fourier transform
	'task': Braket task for quantum fourier transform

WIP: Quantum partition function #17

WIP: Quantum partition function #17

Conversation

AoyuQC commented Nov 14, 2022 • edited Loading

Merge Checklist

General

Tests

review-notebook-app bot commented Dec 12, 2022

zmohammad01 commented Feb 23, 2023

christianbmadsen commented Feb 24, 2023

licedric commented Feb 24, 2023

licedric Feb 24, 2023

Choose a reason for hiding this comment

licedric Feb 24, 2023

Choose a reason for hiding this comment

licedric Feb 24, 2023

Choose a reason for hiding this comment

licedric Feb 24, 2023

Choose a reason for hiding this comment

licedric Feb 24, 2023

Choose a reason for hiding this comment

licedric Feb 24, 2023

Choose a reason for hiding this comment

licedric Feb 24, 2023

Choose a reason for hiding this comment

speller26 commented Feb 24, 2023

codecov-commenter commented Jul 10, 2023 • edited Loading

Codecov Report

peterkomar-aws commented Mar 29, 2024

AoyuQC commented Nov 14, 2022 •

edited

Loading

codecov-commenter commented Jul 10, 2023 •

edited

Loading