Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quantum Neuron #110

Closed
wants to merge 45 commits into from
Closed

Conversation

YutoMorohoshi
Copy link

Issue #, if available:

Description of changes:
added an example about quantum neuron.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@YutoMorohoshi YutoMorohoshi requested a review from math411 May 6, 2023 02:42
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@YutoMorohoshi YutoMorohoshi changed the title yuttaky added an example about quantum neuron May 6, 2023
@YutoMorohoshi YutoMorohoshi changed the title added an example about quantum neuron Quantum Neuron May 6, 2023
@math411 math411 requested a review from licedric May 9, 2023 05:03
@math411
Copy link
Contributor

math411 commented May 9, 2023

Running:

tox

will let the linters fix the formatting issues.

@christianbmadsen
Copy link
Contributor

Would it be possible for you to expand this example to have an actual network use the quantum Neuron?

Returns:
List[float]: List of random numbers.
"""
random.seed(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose for a fixed seed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it reproducible.
Is it not very common to fix seed?

@YutoMorohoshi
Copy link
Author

Would it be possible for you to expand this example to have an actual network use the quantum Neuron?

@christianbmadsen
Thanks for your comments.
At present, I do not think it is very practical to apply quantum neurons to real neural networks. This is because real neural networks are a combination of many neurons, and if we try to do the same thing with quantum neurons, I would expect the quantum circuits to be very deep.

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Patch coverage is 68.49% of modified lines.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Changed Coverage
...mental/algorithms/quantum_neuron/quantum_neuron.py 68.05%
...experimental/algorithms/quantum_neuron/__init__.py 100.00%

📢 Thoughts on this report? Let us know!.

@licedric
Copy link
Contributor

Would it be possible for you to expand this example to have an actual network use the quantum Neuron?

@christianbmadsen Thanks for your comments. At present, I do not think it is very practical to apply quantum neurons to real neural networks. This is because real neural networks are a combination of many neurons, and if we try to do the same thing with quantum neurons, I would expect the quantum circuits to be very deep.

+1 on Christian's request - we'd like to see an actual end-to-end use case here. It's fine if the usage is limited to simulators. Thanks!

@peterkomar-aws
Copy link
Contributor

Hello YutoTakaki, This PR has had little activity; I will close it for now. You are welcome to come back and work on it and reopen it any time. You can also consider developing this work further in a seperate repo of yours and highlighting it on in Braket Algorithm library "Community repos" section, which we recently added. I hope this helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants