Add square blue icon share links variant #4292
Draft
+113
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
position: absolute
for the icons, which doesn't work nicely when we need them square. This is because the absolutely positioned icons don't affect the width/height of the DOM, so adding square padding just ended up in overlapping and bad overflows.display: flex
along withinline-block
to get the styles we want.min-width
at a certain breakpoint to make the reflow look nicer, though this is mainly to make the icons stack a bit nicer on the page we're going to put this variation on as we know which social icons / length of text they will be, so we can kind of control the reflow with themin-width
. Of course it will be a bit of a unnecessary CSS rule if this variation was used on other pages.Visual Changes
New example added, so will need a Percy review.