[WIP] Standardise inverse for search component #4289
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- BREAKING as option name has changed - this is arguably not an 'inverse' version of the component, since it doesn't switch all of the colours from e.g. text black to text white, however I think its better to standardise our component options for ease of understanding - if 'inverse' is always used when a component is on a dark background, it's easier for developers to find and apply that option, even if it doesn't really invert the colours on the component
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update components that have an option for displaying them on a dark background to use
inverseas the option name.Continues the work from #4288. This is more of a breaking change, so holding off on this for now as it's less of a priority.
Why
We're doing some unrelated work with the action link component and the fact that action link uses something other than
inversecauses extra code to be required.For reference, here are all the components I could find prior to starting this PR with an
inverseoption and what they called it:Visual Changes
Should be no actual visual changes apart from some of the names of the examples in the component guide.