WIP - Switch from standardx to eslint with standard config #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[standardx](https://github.com/standard/standardx) appears to be a bit... unmaintained. It's pinning us to a pretty old version of eslint, and a few other dependencies. We switched to using eslint in Whitehall in alphagov/whitehall#8178 We should consider rolling this out everywhere. TODO - more details on what dependencies we're stuck on, and the horrible story of the eslint config file format 🙈
... using the same patterns as we used with standardx
richardTowers
force-pushed
the
eslint-standard
branch
from
7a4d2a3
to
e17cc72
Compare
|
It might be worth a chat with the design system about this idea as we've traditionally tried to align CSS and JS linting across GDS with Design System tending to be the leaders in the decision. We've got it documented in the GDS way to use standard and only switched to standardx for GOV.UK's legacy approach to JS. I do agree that standard seems to not really be a moving project anymore. It'd be cool if we could replace it with something that played nicely with prettier too (I think eslint does) given the CSS linter (stylelint) expects you to have that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standardx appears to be a bit... unmaintained. It's pinning us to a pretty old version of eslint, and a few other dependencies.
We switched to using eslint in Whitehall in alphagov/whitehall#8178
We should consider rolling this out everywhere.
TODO - more details on what dependencies we're stuck on, and the horrible story of the eslint config file format 🙈
What
Why
Visual Changes
Before
After