-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task 801 - launch physical meshes after compilation #938
base: main
Are you sure you want to change the base?
Conversation
mesh_id: int = None | ||
): | ||
super().__init__(host_ids, host_info, num_devices_per_host, parent, devices) | ||
self.host_ips = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This member seems never used. If so, please remove it
@@ -195,6 +195,8 @@ def __init__(self, task_spec, collective_group, src_mesh, dst_mesh): | |||
self.send_worker_task_ids = {} | |||
self.recv_worker_task_ids = {} | |||
|
|||
self.task_dones = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused code. For a series of tasks, we always create a tmp task dones instead of keeping using the same one
@@ -30,12 +30,14 @@ class CreateStateExecutable(PipeshardDriverExecutable): | |||
|
|||
def __init__(self, | |||
mesh_group: PhysicalDeviceMeshGroup, | |||
#virtual_mesh_group: VirtualMeshGroup, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused lines. Also applies for some code below
@@ -100,8 +100,8 @@ def test_pipeshard_parallel(self): | |||
def suite(): | |||
suite = unittest.TestSuite() | |||
suite.addTest(CreateStateTest("test_shard_parallel")) | |||
suite.addTest(CreateStateTest("test_shard_parallel_grad_acc")) | |||
suite.addTest(CreateStateTest("test_pipeshard_parallel")) | |||
#suite.addTest(CreateStateTest("test_shard_parallel_grad_acc")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recover the unit test
No description provided.