Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allure-description-javadoc: mark all java versions as supported #930

Merged
merged 3 commits into from
Jun 28, 2023

Conversation

rPraml
Copy link
Contributor

@rPraml rPraml commented Jun 26, 2023

Context

This change returns the version of the JDK as supported version for the annotation processor.
This avoids warings like Supported source version 'RELEASE_8' from annotation processor ... less than -source 11 so that compiling with -Werror option is possible.

See #929

Checklist

@CLAassistant
Copy link

CLAassistant commented Jun 26, 2023

CLA assistant check
All committers have signed the CLA.

@baev baev added the type:improvement Change that improves some user experience but can't be considered as a new feature label Jun 27, 2023
@baev
Copy link
Member

baev commented Jun 27, 2023

Great work!

@baev
Copy link
Member

baev commented Jun 27, 2023

Please, fix the build

@baev baev changed the title Return latest source version as supported version - allows '-Werror' compile option (fixes #929) allure-description-javadoc: mark all java versions as supported Jun 28, 2023
@baev baev merged commit f9dab79 into allure-framework:master Jun 28, 2023
3 checks passed
@baev
Copy link
Member

baev commented Jun 28, 2023

@rPraml thanks!

@rPraml
Copy link
Contributor Author

rPraml commented Jun 28, 2023

@baev Thanks for releasing 2.23.0 today ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme:descriptions-javadoc type:improvement Change that improves some user experience but can't be considered as a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants