Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #893 - param annotation name not coming up in report #1130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for #893 - param annotation name not coming up in report #1130

wants to merge 1 commit into from

Conversation

mr-possible
Copy link

@mr-possible mr-possible commented Sep 25, 2024 •
edited
Loading

Fixes #893

Context

Before fix:
before-fix

After fix:
after-fix

Checklist

@github-actions github-actions bot added the theme:testng TestNG related issue label Sep 25, 2024
baev
baev requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@baev baev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use wildcard imports. Otherwise — great job 👍

allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java Outdated Show resolved Hide resolved
allure-testng/src/test/java/io/qameta/allure/testng/AllureTestNgTest.java Outdated Show resolved Hide resolved
@baev baev added the type:bug Something isn't working label Sep 25, 2024
@mr-possible
Copy link
Author

hey @baev , can we merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baev baev baev approved these changes

Assignees
No one assigned
Labels
theme:testng TestNG related issue type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation @Param doesn't work with TestNG framework
2 participants
@mr-possible @baev