Datamixer (for SFT) #187
Merged
Datamixer (for SFT) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add yaml files for safety data * update max_seq_length * update max_seq_length
jacob-morrison
requested changes
Jul 22, 2024
There was a problem hiding this comment.
Overall LGTM, three questions/requests in addition to my handful of comments --
- Are we outputting a single jsonl file with the mix created by the data mixer yet? Imo this is important for consistency
- Is there an easy way to use this to create a mix, output a file, and not use it for training? Would be nice to be able to do that to create mixes for EasyLM/TPUs
- Have we tested to make sure we get identical mixes if a seed is set?
* add yaml files for safety data * update max_seq_length * update max_seq_length * update data paths --------- Co-authored-by: Nathan Lambert <[email protected]>
vwxyzjn
reviewed
Jul 24, 2024
Comment on lines
+11
to
+12
| /net/nfs.cirrascale/mosaic/oe-safety-datasets/wildchat_lmsys_sexual/gpt4_lmsys_wildchat_dedup_50ksampled.jsonl: 16888 | ||
| allenai/tulu-v2-sft-mixture: 326154 |
There was a problem hiding this comment.
Maybe it's helpful to specify the percentage instead of the absolute value?
There was a problem hiding this comment.
Percentage also works!
yizhongw
reviewed
Jul 24, 2024
| and "response" in dataset.column_names | ||
| and "messages" not in dataset.column_names | ||
| ): | ||
| dataset = dataset.map(query_response_to_messages, num_proc=10) |
There was a problem hiding this comment.
Probably raise an unsupported error if none is matched?
There was a problem hiding this comment.
Most of the time it'll error if it doesn't match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so you can mix HF and local datasets by proportion of dataset or count of samples, configs like what we had:
Or fractional mixing:
Or count mixing:
Including local files: