New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Playground] 177 auth UI component #280

Merged

justinyoo merged 43 commits into aliencube:main from pmj-chosim:feature/177-auth-ui-component

Sep 16, 2024

Contributor

pmj-chosim commented Aug 31, 2024 •

edited

Loading

<API key input component UI 구현>

API Key Input Component 추가

파일: ApiKeyInputComponent.razor
상세 내용: FluentTextField를 사용하여 마스킹된 API 키 입력 필드를 구현. 이 컴포넌트는 사용자 입력을 받아 내부 상태를 업데이트하고, OnKeyInput 이벤트를 통해 부모 컴포넌트에 입력된 API 키를 전달하는 역할.

Playwright UI 테스트 추가

파일: PlaygroundPageTests.cs
상세 내용: 기존 파일에 API 키 입력 필드 컴포넌트를 테스트하는 Playwright UI 테스트 추가.

API 키 입력 필드가 표시되는지 확인
API 키 입력 필드에 값을 입력했을 때 값이 제대로 업데이트 되는지 확인

pmj-chosim added 4 commits

August 31, 2024 16:55


          Add files via upload

88c3a3d


          testcode

ae6e63a


          add Api key comoponent

e523195


          Action test

1ed7d57

pmj-chosim changed the title ~~177 auth UI component~~ [Playground] 177 auth UI component

justinyoo requested changes

View reviewed changes

Contributor

justinyoo left a comment

수정사항 코멘트 남겨뒀습니다.

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Home.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/DebugApiKeyButton.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/DebugApiKeyButton.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/DebugApiKeyButton.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/DebugApiKeyButton.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/DebugApiKeyButton.cs Outdated Show resolved Hide resolved

justinyoo assigned pmj-chosim

justinyoo added ossca playground team-park task labels

justinyoo linked an issue

that may be closed by this pull request

[Playground] Component for auth (UI only) #177

Closed

pmj-chosim and others added 4 commits

August 31, 2024 17:54


          Merge branch 'aliencube:main' into feature/177-auth-ui-component

6694f2f


          component code(callback) modify

7122e72


          test code modify


          upstream

d29f2a3

Contributor

justinyoo commented Aug 31, 2024

@pmj-chosim 컨플릭 먼저 해결하고 진행하시지욥

pmj-chosim and others added 4 commits

August 31, 2024 19:00


          upstream update

0b7b4f2


          Merge branch 'main' of https://github.com/aliencube/azure-openai-sdk-…

cb4a7d6

…proxy into feature/177-auth-ui-component


          test code modify 1

19f25e6


          test code modify from Assert to FluentAssertions

6a8adfd

Contributor

justinyoo commented Aug 31, 2024

@pmj-chosim PR 본문이 처음엔 있었는데, 자꾸 닫고 열고 하는 과정에서 사라졌네요? PR 본문을 제대로 작성해 주세요.

justinyoo requested changes

View reviewed changes

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Playground.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Home.razor Outdated Show resolved Hide resolved

pmj-chosim and others added 7 commits

August 31, 2024 22:22


          전반적인 수정

1edd331


          update upstream

6c2542f


          Action test

04f3c00


          Merge branch 'aliencube:main' into feature/177-auth-ui-component

96ad4f5


          Update Home.razor

e556a10


          Action error test

302fadf


          Update ApiKeyInputComponent.razor

fa6eac3

justinyoo requested changes

View reviewed changes

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Tests.razor Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

pmj-chosim added 2 commits

September 1, 2024 18:46


          전반적인 수정

0f00ed3


          Merge remote-tracking branch 'upstream/main' into feature/177-auth-ui…

f927e52

…-component

Contributor

justinyoo commented Sep 1, 2024

로컬에서 테스트 돌려보고 올리는 것 맞나요?

justinyoo requested changes

View reviewed changes

Contributor

justinyoo left a comment

지금 현재 테스트 깨지고 있습니다. 로컬에서 테스트 통과하는지 확인한 후에 올려주세요.

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Playground.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Playground.razor Show resolved Hide resolved

pmj-chosim and others added 2 commits

September 3, 2024 12:32


          Merge branch 'aliencube:main' into feature/177-auth-ui-component

5f4c83d


          fluent delete

673ddfd

justinyoo requested changes

View reviewed changes

Contributor

justinyoo left a comment

테스트 관련해서 리뷰 코멘트 남겨뒀습니다.

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Playground.razor Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Tests.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Tests.razor Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Tests.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/Pages/Tests.razor Outdated Show resolved Hide resolved

pmj-chosim added 2 commits

September 6, 2024 02:31


          apikey component razor modify

2ac45c6


          playground page test code modify

badb4aa

pmj-chosim force-pushed the feature/177-auth-ui-component branch from 140e676 to badb4aa Compare

September 5, 2024 18:16

pmj-chosim added 2 commits

September 6, 2024 03:41


          playground.razor apikeycomponent id modify

91f41c9


          add test code for test page

c5326d1

justinyoo requested changes

View reviewed changes

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/TestsPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/TestsPageTests.cs Outdated Show resolved Hide resolved

justinyoo requested changes

View reviewed changes

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/TestsPageTests.cs Outdated Show resolved Hide resolved

pmj-chosim added 3 commits

September 6, 2024 12:16


          testcode for testpage modify about apikeyinputcomponent

14b9955


          sync new merge in upstream

9b55986


          back to test page latest modify: here is 2nd latest modify code

44774cf

justinyoo requested changes

View reviewed changes

Contributor

justinyoo left a comment

아직 코드 리뷰사항 반영이 전부 되어 있지 않습니다.

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/TestsPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/TestsPageTests.cs Outdated Show resolved Hide resolved

src/AzureOpenAIProxy.PlaygroundApp/Components/UI/ApiKeyInputComponent.razor Outdated Show resolved Hide resolved

pmj-chosim and others added 5 commits

September 14, 2024 13:29


          merge conflict modify

fbe0181


          add required and data-type in api component.razor

05c88d8


          Merge branch 'aliencube:main' into feature/177-auth-ui-component

7dc21ab


          playwright package miss commit delete

f2133e3


          Merge branch 'feature/177-auth-ui-component' of https://github.com/pm…

12a4e09

…j-chosim/azure-openai-sdk-proxy into feature/177-auth-ui-component

justinyoo requested changes

View reviewed changes

Contributor

justinyoo left a comment

테스트 페이지 로직은 신경 쓰지 않아도 됩니다. 이제 테스트 페이지는 없어질 거예요.

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/PlaygroundPageTests.cs Outdated Show resolved Hide resolved

test/AzureOpenAIProxy.PlaygroundApp.Tests/Pages/TestsPageTests.cs Outdated Show resolved Hide resolved

pmj-chosim added 2 commits

September 14, 2024 16:38


          delete unnecessary variable in playgroundtest


          delete unnecessary library in testpagestests.cs

b7ab576

justinyoo approved these changes

View reviewed changes

Contributor

justinyoo left a comment

고생하셨습니다! LGTM!

justinyoo merged commit 4c2e4db into aliencube:main

1 check passed

justinyoo mentioned this pull request

[Playground] System Message Tab: UI Component only #289 #312

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ossca playground task team-park