support parameter sync with unbalanced pipe stages #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoda
reviewed
Sep 26, 2024
| layer_re = re.compile(r'layers\.([0-9]+)') | ||
| layer_set = set() | ||
| for name in self.named_parameters: | ||
| layer_num = re.findall(layer_re, name) |
There was a problem hiding this comment.
这里是只匹配layers中的参数？对embedding之类的能否兼容？
There was a problem hiding this comment.
embedding 得到的 layer_num 为空，不会加到layer_set里
There was a problem hiding this comment.
这个 function是计算layer数，embedding 现在没有算一个单独的layer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.