Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Ajv as a named export #2164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jhford-scout24
Copy link

This is solving an issue where it's impossible for me to import Ajv in a typescript project. This solves #2047 for me

import { Ajv } from 'ajv';

What issue does this pull request resolve?

#2047

What changes did you make?

Added a single line exporting Ajv in a slightly different way. I'm not sure if there are any tests on the exported interface.

Is there anything that requires more attention while reviewing?

I don't think so -- this should be a no-op for those who don't use it, and the test suite (yarn test) passes.

This is solving an issue where it's impossible for me to import Ajv in a
typescript project.  This solves ajv-validator#2047 for me

import { Ajv } from 'ajv';
@ajvincent
Copy link

This feels wrong, adding another export.

I think you might want to consult with @dsherret and ask him how he fixed dsherret/code-block-writer#42 - both the wrong way and the right way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants