Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup custom router after creating the Application #104

Merged
merged 3 commits into from
Jun 14, 2023
Merged

Conversation

aamalev
Copy link
Member

@aamalev aamalev commented Jun 5, 2023

Use method of router to setup:

router.setup(app)

For aiohttp<4 use explicit param setup:

router:
   setup: true

Motivation:

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Patch coverage: 94.44% and project coverage change: +0.68 🎉

Comparison is base (95cbebf) 87.99% compared to head (d6dc4a7) 88.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   87.99%   88.67%   +0.68%     
==========================================
  Files          14       15       +1     
  Lines         433      459      +26     
==========================================
+ Hits          381      407      +26     
  Misses         52       52              
Flag Coverage Δ
unittests 88.67% <94.44%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aioworkers_aiohttp/app.py 86.17% <90.00%> (+1.35%) ⬆️
aioworkers_aiohttp/abc.py 100.00% <100.00%> (ø)
tests/test_app.py 100.00% <100.00%> (ø)
tests/test_app_router.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aamalev aamalev merged commit b90eaab into master Jun 14, 2023
@aamalev aamalev deleted the router-setup branch June 14, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant