fix(scan): fix promise/proxy handling and optimize object inspection #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
@pivanov is attempting to deploy a commit to the Million Team on Vercel. A member of the Team first needs to authorize it. |
RobPruzan
reviewed
Dec 12, 2024
RobPruzan
reviewed
Dec 12, 2024
lxsmnsyc
reviewed
Dec 13, 2024
commit: |
lxsmnsyc
reviewed
Dec 17, 2024
lxsmnsyc
reviewed
Dec 17, 2024
lxsmnsyc
reviewed
Dec 17, 2024
lxsmnsyc
reviewed
Dec 17, 2024
- Remove unreliable proxy detection and instanceof checks - Add safer URLSearchParams handling to prevent Next.js errors - Use capability checks instead of type detection - Improve error handling for property access This addresses issues with proxy detection and type checking in the element inspector, making it more reliable across different environments while preventing Next.js-specific errors when handling search params.
RobPruzan
force-pushed
the
main
branch
2 times, most recently
from
7526d13 to
47c46ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the handling of proxy objects and promises and ensures that complex objects, like
Next.jsparams or URLSearchParams, are inspected accurately without errors or performance issues.Key Changes:
These updates fix bugs in the property inspector and ensure a smoother, error-free experience when dealing with complex object types.
Result:
Thanks for the guidance of @RobPruzan 🙇♂️