Add ez-toc-container class to container
#127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the container does not include a base HTML class. So if you want to apply styles to all ToC elements regardless of their configuration, you either have to use the `#ez-toc-container` id (which some might consider bad practice) or use an unnecessarily inconvenient attribute selector (`[class^="ez-toc-"]`). Of course, you could use the `ez_toc_container_class` filter to add it, but you'd need to do this on every project you use the plugin in. By adding a generic `.ez-toc-container` class, none of the "workarounds" would be necessary.
|
A single TOC is on a page, why would not using its |
|
Hi @shazahm1, thanks for getting back to me.
IMHO, when working with an element that has variation, there should always be a "base" class in addition to the classes that describe the variation. Kind of like how BEM works. I'd really appreciate it if you could accept the PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the container does not include a base HTML class.
So if you want to apply styles to all ToC elements regardless of their configuration, you either have to use the
#ez-toc-containerid (which some might consider bad practice) or use an unnecessarily inconvenient attribute selector ([class^="ez-toc-v"]). Of course, you could use theez_toc_container_classfilter to add the class yourself, but you'd need to do this on every project you use the plugin in.By adding a generic
.ez-toc-containerclass, none of the "workarounds" would be necessary.