fix: #61 failing requests for queries with multiple parameters (#63)

* fix: failing requests for queries with multiple parameters

* fix: add unit test to verify request with two params for get request to runPersistedQuery

* chore: remove comment

* chore: remove semicolon to please linter

* fix: fix unit test and implementation

* fix: extend tests to cover use case with no variables and add check for variableString being empty

src/index.js

@@ -109,6 +109,10 @@ class AEMHeadless {
       return `;${key}=${val}`
     }).join(''))
 
+    if (method === 'GET' && variablesString) {
+      variablesString += ';'
+    }
+
     if (method === 'POST') {
       body = JSON.stringify({ variables })
       variablesString = ''

test/shared/index.test.js

@@ -106,7 +106,27 @@ test('API: runPersistedQuery with variables API Success', () => {
 test('API: runPersistedQuery GET with variables API Success', () => {
   // check success response
   const promise = sdk.runPersistedQuery(persistedName, { name: 'test' })
-  expect(fetch).toHaveBeenCalledWith(`http://localhost/graphql/execute.json/${persistedName}%3Bname%3Dtest`, expect.anything(), expect.anything())
+  expect(fetch).toHaveBeenCalledWith(`http://localhost/graphql/execute.json/${persistedName}%3Bname%3Dtest;`, expect.anything(), expect.anything())
+  return expect(promise).resolves.toBeTruthy()
+})
+
+test('API: runPersistedQuery GET with two variables API Success', () => {
+  // check success response
+  const promise = sdk.runPersistedQuery(persistedName, { name: 'test', locale: 'en' })
+  expect(fetch).toHaveBeenCalledWith(`http://localhost/graphql/execute.json/${persistedName}%3Bname%3Dtest%3Blocale%3Den;`, expect.anything(), expect.anything())
+  return expect(promise).resolves.toBeTruthy()
+})
+
+test('API: runPersistedQuery GET with no variables API Success', () => {
+  // check success response
+  const promise = sdk.runPersistedQuery(persistedName)
+  expect(fetch).toHaveBeenCalledWith(`http://localhost/graphql/execute.json/${persistedName}`, expect.anything(), expect.anything())
+  return expect(promise).resolves.toBeTruthy()
+})
+
+test('API: runPersistedQuery GET with no variables API Success and empty variables', () => {
+  const promise = sdk.runPersistedQuery(persistedName, {})
+  expect(fetch).toHaveBeenCalledWith(`http://localhost/graphql/execute.json/${persistedName}`, expect.anything(), expect.anything())
   return expect(promise).resolves.toBeTruthy()
 })