Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add url host type attribute #480

Merged
merged 2 commits into from
Aug 25, 2023
Merged

feat: add url host type attribute #480

merged 2 commits into from
Aug 25, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 25, 2023

This is one of the missing features comparing ada-url rust crate with url crate. Original implementation of url crate is available at: https://docs.rs/url/2.4.0/url/enum.Host.html

@anonrig anonrig requested a review from lemire August 25, 2023 03:31
lemire
lemire approved these changes Aug 25, 2023
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very reasonable

@anonrig anonrig merged commit d192e17 into main Aug 25, 2023
28 checks passed
@anonrig anonrig deleted the add-url-host-type branch August 25, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire