Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary state assignment #471

Merged
merged 1 commit into from
Aug 6, 2023
Merged

fix: remove unnecessary state assignment #471

merged 1 commit into from
Aug 6, 2023

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Aug 6, 2023

The state is assigned inside the next state, and since [[fallthrough]] is used, we don't need to assign it.

@anonrig anonrig requested a review from lemire August 6, 2023 16:47
lemire
lemire approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is likely that the compiler can figure it out… but sure!

@anonrig anonrig merged commit d3223a7 into main Aug 6, 2023
28 checks passed
@anonrig anonrig deleted the fix-coverity-issues branch August 6, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemire lemire lemire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anonrig @lemire