✨ (dashboards) ability to save net-worth widget details #3364

MatissJanis · 2024-09-04T19:08:22Z

Added the ability to save filters & date-ranges on the net worth widgets.

How to use:

open reports page
open a net worth graph (click on it)
in the net worth page: change date-range and maybe add a filter
click save
go back to dashboard
the widget will show the filtered data and with the specific time-range

Feedback is welcome. I plan to implement the same behaviour to the other existing reports too, but starting with just this one.

#3282

netlify · 2024-09-04T19:08:39Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`9eda34d`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66dcbc37eff2ad000869e020
😎 Deploy Preview	https://deploy-preview-3364.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-09-04T19:09:42Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.22 MB → 5.22 MB (+3.49 kB)	+0.07%

Changeset

File	Δ	Size
`src/components/reports/Header.tsx`	🆕 +4.76 kB	0 B → 4.76 kB
`src/icons/v1/Pause.tsx`	🆕 +340 B	0 B → 340 B
`src/icons/v1/Play.tsx`	🆕 +325 B	0 B → 325 B
`home/runner/work/actual/actual/packages/loot-core/src/client/data-hooks/widget.ts`	🆕 +236 B	0 B → 236 B
`src/components/reports/reports/NetWorth.jsx`	📈 +1.39 kB (+30.96%)	4.49 kB → 5.88 kB
`src/components/reports/ReportRouter.tsx`	📈 +164 B (+18.16%)	903 B → 1.04 kB
`src/components/reports/reportRanges.ts`	📈 +425 B (+14.81%)	2.8 kB → 3.22 kB
`src/components/reports/reports/NetWorthCard.tsx`	📈 +220 B (+5.74%)	3.74 kB → 3.96 kB
`src/hooks/useFilters.ts`	📈 +43 B (+2.84%)	1.48 kB → 1.52 kB
`src/components/reports/getLiveRange.ts`	📈 +22 B (+2.04%)	1.05 kB → 1.08 kB
`src/components/common/Button2.tsx`	📈 +24 B (+0.45%)	5.25 kB → 5.27 kB
`src/components/reports/Overview.tsx`	📈 +30 B (+0.19%)	15.62 kB → 15.65 kB
`src/components/reports/ReportSidebar.tsx`	📈 +10 B (+0.06%)	17.67 kB → 17.68 kB
`src/components/reports/reports/CashFlow.tsx`	📉 -244 B (-3.49%)	6.82 kB → 6.58 kB
`src/components/reports/Header.jsx`	🔥 -4.22 kB (-100%)	4.22 kB → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/ReportRouter.js	1.49 MB → 1.5 MB (+3.47 kB)	+0.23%
static/js/index.js	3.26 MB → 3.26 MB (+24 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/usePreviewTransactions.js	1.59 kB	0%
static/js/AppliedFilters.js	21.01 kB	0%
static/js/narrow.js	78.61 kB	0%
static/js/wide.js	224.31 kB	0%

github-actions · 2024-09-04T19:09:43Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.19 MB	0%

youngcw · 2024-09-05T15:44:26Z

The dashboard card doesn't seem to respect the added filters.
Steps:
edited the default net worth report with a new name (working)
set the date range (working)
and added an account filter

The filter is saved and works when viewing the full page report, but the dashboard card doesn't filter down to just the account.

upcoming-release-notes/3364.md

MikesGlitch · 2024-09-05T20:35:26Z

I managed to break it by doing the following:

MatissJanis · 2024-09-05T20:59:29Z

@youngcw - great catch. I forgot to add filters to the dashboard cards 🤦

@MikesGlitch - this looks like a pre-existing issue (visible on edge too). I'll open a separate issue for patching this.

youngcw · 2024-09-06T20:41:00Z

Will the date ranges update automatically still?

MatissJanis · 2024-09-06T20:43:14Z

Will the date ranges update automatically still?

Depends how you select them. If you select a specific date-range via the dropdowns: that will remain static. However, if you select via the buttons (i.e. "past year") - that will auto-magically update.

Now that I'm tying this.. it would make sense to display somewhere an indicator if the selected timeframe is static or a sliding window. Any UX suggestions for that?

youngcw · 2024-09-06T20:46:26Z

You could always make it like the custom reports where you have to decide if its fixed or dynamic.

carkom · 2024-09-07T07:10:09Z

Will the date ranges update automatically still?

Depends how you select them. If you select a specific date-range via the dropdowns: that will remain static. However, if you select via the buttons (i.e. "past year") - that will auto-magically update.

Now that I'm tying this.. it would make sense to display somewhere an indicator if the selected timeframe is static or a sliding window. Any UX suggestions for that?

Something like this?

https://github.com/carkom/actual/blob/bf729ca17bd83434f776de70ddb96e3541699968/packages/desktop-client/src/components/reports/Header.jsx

MatissJanis · 2024-09-07T18:30:29Z

Good idea @carkom ! I used your idea and then slightly built upon that by introducing a play/pause button. That allows us to save vertical space by having just a single button instead of two (+ margins between them).

A question you folks might now ask: why do we still show both the time-frame selector (dropdowns), but also the quick-pick buttons?

I think it makes sense to keep both of these visible at all times. This allows the user to also select, for example, "last 7 months" and then make it "live update". It also allows to quickly select "last 3 months" and then "pause" the timeFrame. Quite a handy feature if you ask me :)

Also: the quick-pick and static selection will automatically update the play/pause state. You can always swap it back.. but by default IMO the quick-pick options should have "play" enabled. And same goes for static selections - those should have "paused" by default, but allow to switch it to "play" if the user wishes so.

Screen.Recording.2024-09-07.at.19.28.10.mov

MatissJanis · 2024-09-07T18:57:11Z

Updated Header component to TS while I'm working in it here.. out for review again!

youngcw · 2024-09-07T19:05:51Z

I think it makes sense to keep both of these visible at all times. This allows the user to also select, for example, "last 7 months" and then make it "live update". It also allows to quickly select "last 3 months" and then "pause" the timeFrame. Quite a handy feature if you ask me :)

Maybe we could look into compressing the quick selections down into a menu or something in the future, but for now it looks good.

carkom · 2024-09-07T19:09:26Z

Looks pretty good!

@MatissJanis can you move filter button to the far right? I'm not sure why it bothers me where it is but it does... 😬

MatissJanis · 2024-09-07T20:44:25Z

Maybe we could look into compressing the quick selections down into a menu or something in the future, but for now it looks good.

@youngcw that's a good idea for future when we need more vertical space there. But for now I think we're good :)

--

@MatissJanis can you move filter button to the far right? I'm not sure why it bothers me where it is but it does... 😬

@carkom Good idea! Moved them to the far right

…#3364)

✨ (dashboards) ability to save net-worth widget details

23d53ad

actual-github-bot bot changed the title ~~✨ (dashboards) ability to save net-worth widget details~~ [WIP] ✨ (dashboards) ability to save net-worth widget details Sep 4, 2024

actual-github-bot bot added the 🚧 WIP label Sep 4, 2024

Release notes

1f96d47

MatissJanis added 3 commits September 4, 2024 20:17

VRT patch

d893e29

Different patch

5d21319

Patch VRT

28db998

MatissJanis changed the title ~~[WIP] ✨ (dashboards) ability to save net-worth widget details~~ ✨ (dashboards) ability to save net-worth widget details Sep 4, 2024

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Sep 4, 2024

MikesGlitch reviewed Sep 5, 2024

View reviewed changes

upcoming-release-notes/3364.md Outdated Show resolved Hide resolved

Feedback: missing filters

9feea49

MatissJanis added 2 commits September 5, 2024 22:07

Translations

9b05789

Merge branch 'master' into matiss/net-worth-save

8a5d5db

MikesGlitch previously approved these changes Sep 5, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Sep 5, 2024

MikesGlitch self-requested a review September 7, 2024 07:41

MatissJanis added 2 commits September 7, 2024 19:18

Feedback: ability to toggle live/paused timeframes

9c2d422

Merge branch 'master' into matiss/net-worth-save

de8a79e

actual-github-bot bot added 🔍 Ready for review and removed ✅ Approved labels Sep 7, 2024

MikesGlitch previously approved these changes Sep 7, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Sep 7, 2024

Patch VRT

9fb4149

MatissJanis dismissed MikesGlitch’s stale review via 9fb4149 September 7, 2024 18:33

actual-github-bot bot added 🔍 Ready for review and removed ✅ Approved labels Sep 7, 2024

MatissJanis added 2 commits September 7, 2024 19:39

Revert filters move to fix VRT

30e75b5

Convert Header to TS

66c3f0c

Feedback: move filters to the right

9338624

Merge branch 'master' into matiss/net-worth-save

9eda34d

MatissJanis requested review from MikesGlitch and youngcw September 9, 2024 17:20

MikesGlitch approved these changes Sep 9, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Sep 9, 2024

youngcw approved these changes Sep 9, 2024

View reviewed changes

MatissJanis merged commit 68a2af0 into master Sep 9, 2024
19 checks passed

MatissJanis deleted the matiss/net-worth-save branch September 9, 2024 19:38

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Sep 9, 2024

MatissJanis mentioned this pull request Sep 11, 2024

[Feedback] Dashboards (reports homepage) #3282

Open

6 tasks

a-gradina pushed a commit to a-gradina/actual that referenced this pull request Sep 15, 2024

✨ (dashboards) ability to save net-worth widget details (actualbudget…

ca888c2

…#3364)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (dashboards) ability to save net-worth widget details #3364

✨ (dashboards) ability to save net-worth widget details #3364

MatissJanis commented Sep 4, 2024 •

edited

Loading

netlify bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

youngcw commented Sep 5, 2024

MikesGlitch commented Sep 5, 2024 •

edited

Loading

MatissJanis commented Sep 5, 2024

youngcw commented Sep 6, 2024

MatissJanis commented Sep 6, 2024

youngcw commented Sep 6, 2024

carkom commented Sep 7, 2024

MatissJanis commented Sep 7, 2024

MatissJanis commented Sep 7, 2024

youngcw commented Sep 7, 2024

carkom commented Sep 7, 2024

MatissJanis commented Sep 7, 2024 •

edited

Loading

✨ (dashboards) ability to save net-worth widget details #3364

✨ (dashboards) ability to save net-worth widget details #3364

Conversation

MatissJanis commented Sep 4, 2024 • edited Loading

netlify bot commented Sep 4, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Sep 4, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Sep 4, 2024 • edited Loading

Bundle Stats — loot-core

youngcw commented Sep 5, 2024

MikesGlitch commented Sep 5, 2024 • edited Loading

MatissJanis commented Sep 5, 2024

youngcw commented Sep 6, 2024

MatissJanis commented Sep 6, 2024

youngcw commented Sep 6, 2024

carkom commented Sep 7, 2024

MatissJanis commented Sep 7, 2024

MatissJanis commented Sep 7, 2024

youngcw commented Sep 7, 2024

carkom commented Sep 7, 2024

MatissJanis commented Sep 7, 2024 • edited Loading

MatissJanis commented Sep 4, 2024 •

edited

Loading

netlify bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

github-actions bot commented Sep 4, 2024 •

edited

Loading

MikesGlitch commented Sep 5, 2024 •

edited

Loading

MatissJanis commented Sep 7, 2024 •

edited

Loading