Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] migrate modals to typescript #3024

Closed
wants to merge 1 commit into from

Conversation

tcrasset
Copy link
Contributor

@tcrasset tcrasset commented Jul 10, 2024

Relates to #1483

@github-actions github-actions bot changed the title migrate modals to typescript [WIP] migrate modals to typescript Jul 10, 2024
Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 0e0bd37
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/668ee10959c73700087c997d
😎 Deploy Preview https://deploy-preview-3024.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.96 MB → 4.96 MB (-120 B) -0.00%
Changeset
File Δ Size
src/components/manager/ManagementApp.tsx 🆕 +6.92 kB 0 B → 6.92 kB
src/components/manager/Modals.tsx 🆕 +1.97 kB 0 B → 1.97 kB
src/components/manager/ManagementApp.jsx 🔥 -6.92 kB (-100%) 6.92 kB → 0 B
src/components/manager/Modals.jsx 🔥 -2.09 kB (-100%) 2.09 kB → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/index.js 3.21 MB → 3.21 MB (-120 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/narrow.js 76.72 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/AppliedFilters.js 27.5 kB 0%
static/js/wide.js 272.7 kB 0%
static/js/ReportRouter.js 1.23 MB 0%

Copy link
Contributor

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.13 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.13 MB 0%

Copy link
Contributor

👋 Hi! It looks like this PR has not had any changes for a week now. Would you like someone to review this PR? If so - please remove the "[WIP]" prefix from the PR title. That will let the community know that this PR is open for a review.

@github-actions github-actions bot added the Stale label Jul 29, 2024
Copy link
Contributor

github-actions bot commented Aug 4, 2024

This PR was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants