Add internationalisation framework #205

TomAFrench · 2022-08-24T00:21:47Z

There's been some interest in adding translations for languages other than english here: https://github.com/actualbudget/actual/discussions/199

I can't really work on this myself personally due time + language knowledge constraints but I'm leaving this PR open so that anyone can contribute translations to be merged into this PR and once we have more coverage then we can work on getting it merged into master (we'll need to add the ability to set the language in the UI, etc.).

For the time being you can choose which language to display by setting the lng flag in src/locales/index.js. We currently have very barebones i18n files which only handle a couple of strings on the bootstrapping page.

These files need to be filled out and new ones created for any languages we want to support. To use these these translations, all the components in the app need to be updated in a similar fashion to the Bootstrap component (please use that component as a guide).

TomAFrench · 2022-08-24T16:42:20Z

@manuelcanepa There was a couple of issues which popped up but it's pretty much there:

There was a mismatch on the translation key used in the json file compared to in the React code.
Templated values need to be wrapped {{twice}} instead of {once}.
It seems like the t() function doesn't properly display <strong> tags so we need to use the <Trans> component in these cases.

If you run yarn start in the terminal then you should be able to check whether the translations appear correctly in the app.

manuelcanepa · 2022-08-24T16:55:54Z

Thanks for the corrections, im having troubles to start this project, so i make changes without running. Today i will try to start the environment to check every change that i makes.

TomAFrench · 2022-08-24T16:57:31Z

Ok, feel free to share any errors you're getting and we can see if we can work it out together.

* master: (24 commits) refactor: sort imports in desktop-client alphabetically chore: remove unused imports from desktop-client adm-zip to 0.5.6 style: prettify .eslintrc.js build: make eslint-plugin-prettier a dependency of desktop-client ci: lint desktop-client in CI style: fix or silence linting errors in desktop-client chore: update remaining test scripts github fix indentation in issue template github: update issue template fix: correct some re-exports which were breaking things fix: stop trying to transform node_modules fix: stop the web tests from running in node environment fix: add ts-jest presets which are equivalent to the old `transform` properties fix: add esModuleInterop so that the default imports issue goes away fix: stop typechecking javascript files chore: allow mobile package to pass with no tests build: replace babel-jest with ts-jest Update bug-report.yml Addition: Issue template ...

manuelcanepa · 2022-08-30T12:10:25Z

@TomAFrench I dont have write access, thats why i can't contribute directly to this PR and open #219. BTW: I notice that .editorconfig says:

[*]
indent_size = 2

And you indent json with 4 spaces, i propose you to add:

[*.json]
indent_size = 4

TomAFrench · 2022-08-30T12:48:09Z

Whoops, sorry looks like my vscode wasn't respecting .editorconfig, that should be fixed now. I'll just use 2 spaces from now on.

I dont have write access, thats why i can't contribute directly to this PR and open #219.

Thanks, yeah making separate PRs into this branch is the way to go. I'll try to review and merge promptly.

@j-f1

* #199 Adding translation to schedules list * #199 Complete translation on EditSchedule Form * #199 Translation for status badge * #199 Minor changes, suggested by @j-f1 Co-authored-by: Tom French <[email protected]>

* master: fix: use correct comment style build: remove patch-package dependency from loot-design Conditionally set MSYS build: update yarn.lock build: use workspace ranges for monorepo dependencies changes needed to build on windows

manuelcanepa · 2022-08-31T02:49:14Z

I think that this will be a headache to translate: https://github.com/actualbudget/actual/blob/i18n/packages/loot-core/src/shared/schedules.js

j-f1 · 2022-08-31T13:33:25Z

Working on that @manuelcanepa!

* master: Sort import in alphabetical order (#238) Separate external, monorepo and internal imports (#237) Allow `enter` to create new transaction when focused on `cleared` column (#234) Enforce linting in loot-design (#233) style: run linter (#232) refactor: create index.js for aql directory (#68) Revert "build: update yarn.lock" (#230) Fix handling of -0 in budget summary (#229) Update bug-report.yml (#228)

manuelcanepa · 2022-09-02T16:05:15Z

I see that the "es" language is fixed on config. @TomAFrench What do you think about this: https://github.com/i18next/i18next-browser-languageDetector?

* #199 Adding translation to rule editor and transaction table * Feature: Translation to discover schedule table Fix: Some translation improvements * fix: Fix minor after check * Feature: More translation to account Fix: Add *_old.json files to ignore * Update packages/desktop-client/src/components/accounts/Account.js Co-authored-by: Tom French <[email protected]> * fix: Workaround for know caveats * lint: fix import order * fix: t is not a function when empty transactions list * Feature: Translate account filters * Feature: Translation on transactions table * Feature: Translate budget and the rest of bootstrap * Update packages/desktop-client/src/locales/es-ES.json Co-authored-by: Jed Fox <[email protected]> * fix: Using the new key for unknow error * refactor: push useTranslation up above function definition, etc * refactor: push useTranslation up above function definition * refactor: set key for Trans component balanceType * refactor: pass i18keys to Trans components explicitly Co-authored-by: Tom French <[email protected]> Co-authored-by: Jed Fox <[email protected]>

TomAFrench · 2022-09-08T13:24:14Z

I haven't put much thought into the language selection so far. We should definitely add a dropdown to the settings page but not sure if we need this package vs storing it in local storage ourselves.

* monthUtils.{format → nonLocalizedFormat} * Implement localization for schedule descriptions * Remove outdated comment * Add general.ordinal in Spanish Co-Authored-By: Manuel Eduardo Cánepa Cihuelo <[email protected]> * yay time zones? * fix: re-add missing keys * fix: fix broken i18n imports/initialisation * style: linting * fix: re-add english ordinal keys * fix: add remaining english ordinal keys * fix: correct dates in schedules.js * refactor: store translations keys for loot-core in loot-core * fix: add ns to i18n.t calls directly so parser can find them * feat: add spanish translation from manuelcanepa * fix: add comments to help i18n-parser to find contexts * fix: add "many" context to spanish translations Co-authored-by: Manuel Eduardo Cánepa Cihuelo <[email protected]> Co-authored-by: Tom French <[email protected]>

Co-authored-by: Manuel Eduardo Cánepa Cihuelo <[email protected]>

manuelcanepa · 2022-09-08T15:04:45Z

packages/desktop-client/package.json

+    "i18next": "^21.9.1",
+    "i18next-parser": "^6.5.0",


Why is on devDependencies?

This reverts commit adbaf27.

manuelcanepa · 2022-12-16T20:53:40Z

What do we need to make this happend?

MatissJanis · 2023-01-26T22:17:16Z

Closing this one off as abandoned. But linking to this PR from an issue so if someone decides to pick this up again can refer back to this PR.

#497

vfaculteit · 2023-05-08T20:14:36Z

I'd like to continue working on this, could you please reopen the i18n branch @MatissJanis? Also, for readability purposes we could directly add fallback translations, e.g., the string "Accounts" becomes t('general.accounts', "Accounts") in stead of t('general.accounts').

manuelcanepa · 2023-05-08T20:21:51Z

I'd like to continue working on this, could you please reopen the i18n branch @MatissJanis? Also, for readability purposes we could directly add fallback translations, e.g., the string "Accounts" becomes t('general.accounts', "Accounts") in stead of t('general.accounts').

I like it, how this works with interpolation?

vfaculteit · 2023-05-08T21:05:40Z

I'd like to continue working on this, could you please reopen the i18n branch @MatissJanis? Also, for readability purposes we could directly add fallback translations, e.g., the string "Accounts" becomes t('general.accounts', "Accounts") in stead of t('general.accounts').

I like it, how this works with interpolation?

This should work: e.g., `Account: ${accountName}` becomes t('general.accountWithName', {name: accountName, defaultValue: 'Account: {{name}}'}

fabienheureux · 2023-06-23T15:50:23Z

@vfaculteit did you start working on this ?
I might be interested to help as well, French speaker here, with experience in translating react projects.
I don't want to duplicate the effort, let me know if there are areas where you think you might need some help.

fabienheureux · 2023-06-26T08:53:58Z

Great, glad to see the work is in progress !
No rush in getting access to the repo, I can follow from there and check where I can be of any help, and base some work on this branch.

Are there any blockers I could help with ?

rafacla · 2023-07-02T15:10:09Z

Hello guys, brazilian here, can help translating to pt-BR

maxloo2 · 2023-08-16T12:57:28Z

@MatissJanis will this PR be reopened?

lelemm · 2024-02-05T11:42:40Z

I can help too

Hello guys, brazilian here, can help translating to pt-BR

feat: add skeleton of i18n framework

fd0d30c

TomAFrench added good first issue Good for newcomers help wanted Extra attention is needed labels Aug 24, 2022

#199 Adding some translation to check if im doing right

9b3dbd1

manuelcanepa mentioned this pull request Aug 24, 2022

#199 Adding some translation to check if im doing right #206

Merged

TomAFrench added 2 commits August 24, 2022 17:21

fix: ensure that translation keys match

dd9d32a

fix: get bold tags to display correctly

2d025d8

TomAFrench added 5 commits August 30, 2022 10:24

feat: prevent translation keys which don't exist in locale files

5c56370

feat: fallback to english rather than showing translation key

a4fe219

ci: correct i18n job name

1fd3234

ci: fix workspace name in i18n job

b0f0c4a

style: format json with 2 space indents

304a384

TomAFrench mentioned this pull request Aug 30, 2022

#199 Adding translation to schedules list #219

Merged

manuelcanepa and others added 3 commits August 30, 2022 23:22

#199 Adding translation to schedules list (#219)

e436c01

* #199 Adding translation to schedules list * #199 Complete translation on EditSchedule Form * #199 Translation for status badge * #199 Minor changes, suggested by @j-f1 Co-authored-by: Tom French <[email protected]>

Merge branch 'master' into i18n

618dd0f

* master: fix: use correct comment style build: remove patch-package dependency from loot-design Conditionally set MSYS build: update yarn.lock build: use workspace ranges for monorepo dependencies changes needed to build on windows

refactor: use i18n-next style of plurals

55049da

TomAFrench force-pushed the i18n branch from a793fbd to 55049da Compare August 30, 2022 23:20

style: remove setting of indent size to 4 in i18n-parser config

9538467

TomAFrench added 2 commits September 2, 2022 15:10

style: linting

cbf1e18

j-f1 and others added 2 commits September 8, 2022 14:37

fix: correct "_many" translations

adbaf27

Co-authored-by: Manuel Eduardo Cánepa Cihuelo <[email protected]>

manuelcanepa reviewed Sep 8, 2022

View reviewed changes

Revert "fix: correct "_many" translations"

f5d9f30

This reverts commit adbaf27.

MatissJanis mentioned this pull request Dec 29, 2022

Feature: Translate loot-design #249

Closed

rich-howell added the user interface Related to the user interface label Jan 7, 2023

MatissJanis mentioned this pull request Jan 26, 2023

[Feature] Translation #497

Closed

MatissJanis closed this Jan 26, 2023

MatissJanis deleted the i18n branch May 4, 2023 17:31

julianwachholz mentioned this pull request Jul 11, 2024

feat: introduce i18n framework #3036

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add internationalisation framework #205

Add internationalisation framework #205

TomAFrench commented Aug 24, 2022

TomAFrench commented Aug 24, 2022 •

edited

Loading

manuelcanepa commented Aug 24, 2022

TomAFrench commented Aug 24, 2022

manuelcanepa commented Aug 30, 2022

TomAFrench commented Aug 30, 2022

manuelcanepa commented Aug 31, 2022 •

edited

Loading

j-f1 commented Aug 31, 2022

manuelcanepa commented Sep 2, 2022

TomAFrench commented Sep 8, 2022

manuelcanepa Sep 8, 2022

manuelcanepa commented Dec 16, 2022

MatissJanis commented Jan 26, 2023

vfaculteit commented May 8, 2023

manuelcanepa commented May 8, 2023

vfaculteit commented May 8, 2023 •

edited

Loading

fabienheureux commented Jun 23, 2023

fabienheureux commented Jun 26, 2023

rafacla commented Jul 2, 2023

maxloo2 commented Aug 16, 2023

lelemm commented Feb 5, 2024

Add internationalisation framework #205

Add internationalisation framework #205

Conversation

TomAFrench commented Aug 24, 2022

TomAFrench commented Aug 24, 2022 • edited Loading

manuelcanepa commented Aug 24, 2022

TomAFrench commented Aug 24, 2022

manuelcanepa commented Aug 30, 2022

TomAFrench commented Aug 30, 2022

manuelcanepa commented Aug 31, 2022 • edited Loading

j-f1 commented Aug 31, 2022

manuelcanepa commented Sep 2, 2022

TomAFrench commented Sep 8, 2022

manuelcanepa Sep 8, 2022

Choose a reason for hiding this comment

manuelcanepa commented Dec 16, 2022

MatissJanis commented Jan 26, 2023

vfaculteit commented May 8, 2023

manuelcanepa commented May 8, 2023

vfaculteit commented May 8, 2023 • edited Loading

fabienheureux commented Jun 23, 2023

fabienheureux commented Jun 26, 2023

rafacla commented Jul 2, 2023

maxloo2 commented Aug 16, 2023

lelemm commented Feb 5, 2024

TomAFrench commented Aug 24, 2022 •

edited

Loading

manuelcanepa commented Aug 31, 2022 •

edited

Loading

vfaculteit commented May 8, 2023 •

edited

Loading