Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. #2004

Merged

Conversation

MikesGlitch
Copy link
Contributor

@MikesGlitch MikesGlitch commented Dec 1, 2023

Convert BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript.

#1483

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 90054c0
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/656ba8ec7672df00086b5b48
😎 Deploy Preview https://deploy-preview-2004.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.08 MB → 3.08 MB (-12 B) -0.00%
Changeset
File Δ Size
src/components/manager/Import.tsx 🆕 +4.77 kB 0 B → 4.77 kB
src/components/budget/BudgetTotals.tsx 🆕 +4.69 kB 0 B → 4.69 kB
src/components/manager/WelcomeScreen.tsx 🆕 +3.82 kB 0 B → 3.82 kB
src/components/reports/DateRange.js 🆕 +1.03 kB 0 B → 1.03 kB
src/components/gocardless/GoCardlessLink.tsx 🆕 +922 B 0 B → 922 B
src/components/reports/useReport.js 🆕 +542 B 0 B → 542 B
src/components/manager/Import.js 🔥 -4.77 kB (-100%) 4.77 kB → 0 B
src/components/budget/BudgetTotals.js 🔥 -4.69 kB (-100%) 4.69 kB → 0 B
src/components/manager/WelcomeScreen.js 🔥 -3.81 kB (-100%) 3.81 kB → 0 B
src/components/reports/DateRange.tsx 🔥 -1.07 kB (-100%) 1.07 kB → 0 B
src/components/gocardless/GoCardlessLink.js 🔥 -922 B (-100%) 922 B → 0 B
src/components/reports/useReport.tsx 🔥 -542 B (-100%) 542 B → 0 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/main.js 1.26 MB → 1.26 MB (+7 B) +0.00%
static/js/wide-components.chunk.js 113.85 kB → 113.85 kB (+1 B) +0.00%

Smaller

Asset File Size % Changed
static/js/reports.chunk.js 74.98 kB → 74.96 kB (-20 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/narrow-components.chunk.js 52.61 kB 0%
static/js/226.chunk.js 28.82 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@MikesGlitch MikesGlitch changed the title adding types to some modals Convert BudgetTotals, GoCardlessLink, Import components to Typescript. Dec 1, 2023
@MikesGlitch MikesGlitch marked this pull request as ready for review December 2, 2023 10:19
@MikesGlitch MikesGlitch changed the title Convert BudgetTotals, GoCardlessLink, Import components to Typescript. Convert BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. Dec 2, 2023
@MikesGlitch MikesGlitch changed the title Convert BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. Dec 2, 2023
@MikesGlitch MikesGlitch changed the title BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. [Maintenance] BudgetTotals, GoCardlessLink, Import, WelcomeScreen components to Typescript. Dec 2, 2023
@MikesGlitch MikesGlitch force-pushed the maintenance/add-types-to-modals branch from 7e841f7 to 947f269 Compare December 2, 2023 19:33
MatissJanis
MatissJanis previously approved these changes Dec 2, 2023
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Thanks for all these TS improvements. Always nice to see them and easy to review.

Let me know what you think about my comment. Not a blocker for merging.

packages/loot-core/src/client/actions/budgets.ts Outdated Show resolved Hide resolved
@MikesGlitch MikesGlitch force-pushed the maintenance/add-types-to-modals branch from 94cb6ac to 90054c0 Compare December 2, 2023 22:00
@MikesGlitch
Copy link
Contributor Author

Overall LGTM! Thanks for all these TS improvements. Always nice to see them and easy to review.

Let me know what you think about my comment. Not a blocker for merging.

Nice, done.

@MatissJanis MatissJanis merged commit f36713e into actualbudget:master Dec 2, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Dec 2, 2023
@MikesGlitch MikesGlitch deleted the maintenance/add-types-to-modals branch December 2, 2023 22:43
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants