Maintenance: BudgetSummary & CreateLocalAccount to tsx #1768
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -26,7 +33,7 @@ function CreateLocalAccount({ modalProps, actions }) { | |||
| let validateBalance = balance => !isNaN(parseFloat(balance)); | |||
|
|
|||
| return ( | |||
| <Modal title="Create Local Account" {...modalProps} showBack={false}> | |||
There was a problem hiding this comment.
"showBack" is not a valid property for Modal - it does nothing. This is the only place where a showBack prop is set on Modal - I think this may be old code.
The Back button logic is handled inside this component - verified it still works.
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
| @@ -8,7 +8,7 @@ type InlineFieldProps = { | |||
| label: ReactNode; | |||
| labelWidth?: number; | |||
| children?: ReactNode; | |||
| width: number; | |||
| width: number | string; | |||
There was a problem hiding this comment.
width is being used as a string like:
width: '75%'
numbers are also valid. width: 100 would mean 100px
|
|
||
| return ( | ||
| <Modal title="Budget Details" {...modalProps} animate> | ||
| <Modal title="Budget Details" {...modalProps}> |
There was a problem hiding this comment.
Removed animate prop as it doesn't get used by anything as far as I can see. It's nowhere else in the code - seems like an anomaly.
Verified, it is still working as before:
| @@ -1,9 +1,10 @@ | |||
| import React from 'react'; | |||
|
|
|||
| import { rolloverBudget } from 'loot-core/src/client/queries'; | |||
| import * as monthUtils from 'loot-core/src/shared/months'; | |||
There was a problem hiding this comment.
Only importing what's needed
| @@ -164,7 +164,7 @@ type SingleAutocompleteProps = { | |||
| openOnFocus?: boolean; | |||
| getHighlightedIndex?: (suggestions) => number | null; | |||
| highlightFirst?: boolean; | |||
| onUpdate: (id: unknown, value: string) => void; | |||
| onUpdate?: (id: unknown, value: string) => void; | |||
There was a problem hiding this comment.
This is optional - it's rarely specified - found it when looking in another area.
MikesGlitch
changed the title
trafico-bot
bot
added
✨ Merged
Convert BudgetSummary modal(mobile) and CreateLocalAccounts components to TypeScript.
Relates to : #1483