TypeScript migration (partial). #1671
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
| @@ -164,7 +164,7 @@ export function addSplitTransaction(transactions, id) { | |||
| if (!trans.is_parent) { | |||
| return trans; | |||
| } | |||
There was a problem hiding this comment.
Making last into a typed generic in util.ts bubbled up type issues to transactions.ts. This is the only location in the codebase using last, so it seemed most practical to just remove it.
| onError={setError} | ||
| onError={err => setError(err)} |
There was a problem hiding this comment.
🥜 nitpick: I don't think this change is necessary
| onError={setError} | ||
| onError={err => setError(err)} |
| await setServerUrl(null); | ||
| await setServerUrl(''); |
There was a problem hiding this comment.
🔨 warning: we need to keep null here.
actual/packages/loot-core/src/server/main.ts
Line 1775 in a8a0f77
| await setServerUrl(null); | ||
| await setServerUrl(''); |
| @@ -21,7 +21,7 @@ function ItemContent({ | |||
| forceActive, | |||
| children, | |||
| }: ItemContentProps) { | |||
| return onClick ? ( | |||
| return onClick || !to ? ( | |||
There was a problem hiding this comment.
💭 thought: I don't think we need this change.
| to?: string; | ||
| onClick?: MouseEventHandler<HTMLDivElement>; |
There was a problem hiding this comment.
❓ question: is it that there can be either to or onClick? But not both at the same time? If so - we could solve it by changing the types slightly.
(very poor naming chosen here intentionally as this is just an example)
type BaseProps = { style: CSSProperties };
type ItemContentProps = AProps | BProps;
type AProps = BaseProps & { to: string };
type BProps = BaseProps & { onClick: () => void };
trafico-bot
bot
added
⚠️ Changes requested
|
Thanks for the feedback. Going to close this PR for now since it is stale and some of the changes have already been addressed in other merged PRs. |
Working through some of the TypeScript migrations/hardening when running
yarn tsc --strict.Found 3531 errors in 249 files. -> Found 3500 errors in 240 files.Related: #1483