This repository has been archived by the owner on Mar 30, 2022. It is now read-only.
Fixes #379 #401
Open
Fixes #379 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since polyamorous 1.1.0 [differs from 1.2.0](activerecord-hackery/polyamorous@ca95023) only by the version number and the README file, it's perfectly unacquired to simply change the dependency version. Copied from [5bf84bd](activerecord-hackery/squeel@5bf84b) which is not on the master branch, so can't be referenced.
…rphic joins erros in squeel (activerecord-hackery#369 and activerecord-hackery#380).
ruby 2.4 deprecated Fixnum and Bignum, replacing them with a single unified Integer class.
Fix 'NoMethodError: undefined method `last_comment'' errors when trying to run rake for this gem. Rake 11.0.1 removes the last_comment method which rspec-core (< 3.4.4) uses. Therefore until/if a patch is released we need to pin rake to an older version in Gemfile: gem 'rake', '< 11.0' Then: bundle exec rake install https://stackoverflow.com/questions/35893584/nomethoderror-undefined-method-last-comment-after-upgrading-to-rake-11
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since polyamorous 1.1.0 differs from 1.2.0 only by the version number and the README file, it's perfectly unacquired to simply change the dependency version.
Copied from 5bf84bd which is not on the master branch, so can't be referenced.