Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve browse page loading experience #509

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Improve browse page loading experience #509

merged 4 commits into from
Jun 10, 2024

Conversation

dabreegster
Copy link
Contributor

  1. Add a progress bar to the browse page
  2. Add a URL parameter disable_schemes=1 to not do this automatically, for later use in inspectorate tools

I had to use https://www.danvega.dev/blog/network-throttling#chrome-devtools to test the progress bars, but if you have access to naturally slow internet, even easier ;)

Demo of second feature: https://acteng.github.io/atip/pipeline/browse.html?disable_schemes=1

Pete-Y-CS
Pete-Y-CS approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@Pete-Y-CS Pete-Y-CS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine locally for me! I get to see a little bit of downloading time and sharing fetchWithProgress is good!

@dabreegster dabreegster merged commit 62df4aa into main Jun 10, 2024
2 checks passed
@dabreegster dabreegster deleted the browse_loading branch June 10, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pete-Y-CS Pete-Y-CS Pete-Y-CS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dabreegster @Pete-Y-CS