Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the Transcript Rules #2064

Open
wants to merge 58 commits into
base: develop
Choose a base branch
from
Open

Updating the Transcript Rules #2064

wants to merge 58 commits into from

Conversation

HelenBurge
Copy link
Collaborator

@HelenBurge HelenBurge commented May 25, 2023

Are being updated from Task force feedback

Amending the rule from TF feedback: https://docs.google.com/spreadsheets/d/1OSkPFocXk4K3zYLnwS78WLsWO4PvE5yRcsauyefuIUI/edit#gid=1605073031

Closes issue(s):

Need for Call for Review:
This will require a 2 weeks Call for Review


How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@HelenBurge HelenBurge changed the title TranscriptRules Updating the Transcript Rules May 25, 2023
@HelenBurge HelenBurge self-assigned this May 25, 2023
@HelenBurge HelenBurge added ACT TF request WCAG-TF review Items for review by WCAG-TF participants labels May 25, 2023
@HelenBurge HelenBurge marked this pull request as ready for review May 25, 2023 11:13
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/video-only-transcript-ee13b5.md Outdated Show resolved Hide resolved
_rules/video-only-transcript-ee13b5.md Show resolved Hide resolved
_rules/video-transcript-1a02b0.md Show resolved Hide resolved
Jym77
Jym77 previously requested changes Jun 29, 2023
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
@daniel-montalvo
Copy link
Collaborator

Discussed at the TF meeting 29 Feb
https://www.w3.org/2024/02/29-wcag-act-minutes.html#t03

@HelenBurge HelenBurge dismissed Jym77’s stale review February 29, 2024 21:07

I have made updates to hopefully resolve the feedback you had!

Copy link
Collaborator

@Jym77 Jym77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not super happy with the inclusion in the accessibility tree part 😅


From the TF discussion, I think I understand that TF reached the consensus that an inaccessible transcript is not always a 1.2.1 failure.

If this is indeed the case, then yes, we need to remove it (and the corresponding Failed Example). But in this case I'd like us to have a Passed example with an accessible transcript that is not failing 1.2.1. This will serve as documentation of this decision and essentially say: "no, inclusion in the accessibility tree is not required, look at this". (and if people disagree with this decision in the future, we'll have the example to foster concrete discussions instead of doing archaeology in Github history.

If I'm reading that wrong and that the issue with inaccessible transcripts is that they fail both 1.2.1 and 1.3.1, then I think that a better solution would be to add 1.3.1 as a related secondary requirement; this is similar to the secondary requirement to 1.1.1 for "link have accessible name" (due to area elements)

_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Show resolved Hide resolved
_rules/video-only-transcript-ee13b5.md Outdated Show resolved Hide resolved
_rules/video-only-transcript-ee13b5.md Outdated Show resolved Hide resolved
_rules/video-transcript-1a02b0.md Outdated Show resolved Hide resolved
Amended the updated of unmuted as the term is not recognised so used "not mute" instead.
@HelenBurge HelenBurge requested a review from kengdoj June 27, 2024 14:18
@kengdoj
Copy link
Collaborator

kengdoj commented Jul 1, 2024

I couldn't add this in my review comments - Like the change you made in 2eb176, please change this failed example 4 to passed example 3 in ee13b5.

Failed Example 4

This video element, which has no audio, has a text transcript available on the same page, but the transcript is not [included in the accessibility tree][].

<html lang="en">
<video controls>
  <source src="/test-assets/rabbit-video/silent.mp4" type="video/mp4"></source>
  <source src="/test-assets/rabbit-video/silent.webm" type="video/webm"></source>
</video>
<p aria-hidden="true">The above video shows a giant fat rabbit climbing out of a hole in the ground.
He stretches, yawns, and then starts walking.
Then he stops to scratch his bottom.</p>
</html>

kengdoj
kengdoj previously requested changes Jul 1, 2024
_rules/audio-transcript-2eb176.md Show resolved Hide resolved
_rules/audio-transcript-2eb176.md Outdated Show resolved Hide resolved
_rules/video-only-transcript-ee13b5.md Outdated Show resolved Hide resolved
_rules/video-transcript-1a02b0.md Outdated Show resolved Hide resolved
_rules/video-transcript-1a02b0.md Outdated Show resolved Hide resolved
@HelenBurge HelenBurge requested a review from kengdoj August 1, 2024 14:01
@HelenBurge HelenBurge dismissed kengdoj’s stale review August 1, 2024 14:12

Actioned the items

Copy link
Member

@carlosapaduarte carlosapaduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments about the autoplay attribute


- playing; or,
- has a [play button][] that is [visible][] and [included in the accessibility tree][].
- the element has an [autoplay][] [attribute value][] of `true`; or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since autoplay here is referring to the HTML attribute I don't think it needs to link to the definition.

@@ -81,7 +88,7 @@ This `audio` element has native player controls and an external transcript.

#### Passed Example 3

This `audio` element has an `autoplay` attribute and an external transcript.
This `audio` element has an [autoplay][] attribute and an external transcript.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since autoplay here is referring to the HTML attribute I don't think it needs to link to the definition.

@@ -131,7 +154,7 @@ This `audio` element has native player controls and an incorrect external transc

#### Failed Example 4

This `audio` element has an `autoplay` attribute and an incorrect external transcript.
This `audio` element has an [autoplay][] attribute and an incorrect external transcript.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since autoplay here is referring to the HTML attribute I don't think it needs to link to the definition.


## Accessibility Support

There are no accessibility support issues known.

## Background

Some major browsers do not automatically play the 'video' unless it is muted, which makes the rule inapplicable in these browsers. The rule still applies to browsers that [autoplay][] an audible 'video'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should link to the autoplay definition, but since it is being used in the Background section, the definition doesn't need to be objective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACT TF request reviewers wanted WCAG-TF review Items for review by WCAG-TF participants
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants