Fix #61: Exclude .module files from type hint requirements (#66)

* Fix #61: Exclude .module files from type hint requirements * docroot name, add install files
acquia · Apr 11, 2024 · c24be34 · c24be34
1 parent 937fa1b
commit c24be34
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/src/Standards/AcquiaDrupalStrict/ruleset.xml b/src/Standards/AcquiaDrupalStrict/ruleset.xml
@@ -35,4 +35,19 @@
   <!-- Acquia PHP sniffs -->
   <rule ref="AcquiaPHP"/>
 
+  <!-- Drupal should type hint hooks -->
+  <!-- @see https://www.drupal.org/project/drupal/issues/3229216 -->
+  <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingAnyTypeHint">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+
 </ruleset>
diff --git a/src/Standards/AcquiaDrupalTransitional/ruleset.xml b/src/Standards/AcquiaDrupalTransitional/ruleset.xml
@@ -35,4 +35,19 @@
   <!-- Acquia PHP sniffs -->
   <rule ref="AcquiaPHP"/>
 
+  <!-- Drupal should type hint hooks -->
+  <!-- @see https://www.drupal.org/project/drupal/issues/3229216 -->
+  <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingTraversableTypeHintSpecification">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.ReturnTypeHint.MissingAnyTypeHint">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingAnyTypeHint">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+  <rule ref="SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingTraversableTypeHintSpecification">
+    <exclude-pattern>*/modules/custom/*/*\.(module|install)$</exclude-pattern>
+  </rule>
+
 </ruleset>