Skip to content

Commit

Permalink
check_yaml: Always run schema validation (instructlab#1079)
Browse files Browse the repository at this point in the history
We no longer skip schema validation if linting reports an error.

Signed-off-by: BJ Hargrave <[email protected]>
  • Loading branch information
bjhargrave authored and jjasghar committed Jun 10, 2024
1 parent 8e0d451 commit 0c8a55e
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions .github/scripts/check-yaml.py
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ def check(self) -> int:
with open(full_path, "r", encoding="utf-8") as stream:
content = stream.read()

lint_error = False
for lint_problem in linter.run(
input=content, conf=self.yamllint_config
):
Expand All @@ -144,16 +143,13 @@ def check(self) -> int:
line=lint_problem.line,
col=lint_problem.column,
)
lint_error = True
case _:
self.warning(
file=taxonomy_path,
message=message,
line=lint_problem.line,
col=lint_problem.column,
)
if lint_error:
continue

parsed = yaml.safe_load(content)
if not parsed:
Expand Down

0 comments on commit 0c8a55e

Please sign in to comment.