NOISSUE - Fix list domain users #2369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
force-pushed
the
NOISSUE-fixListUserInDomain
branch
from
eb3261b to
b329a41
Compare
dborovcanin
requested changes
Aug 1, 2024
users/service.go
Outdated
Comment on lines
547
to
556
| if nameQuery != "" { | ||
| filteredClients := make([]mgclients.Client, 0, len(cp.Clients)) | ||
| for _, c := range cp.Clients { | ||
| if strings.Contains(c.Name, nameQuery) { | ||
| filteredClients = append(filteredClients, c) | ||
| } | ||
| } | ||
| cp.Clients = filteredClients | ||
| } |
There was a problem hiding this comment.
This type of filter will result in the incorrect total count.
ianmuchyri
approved these changes
Aug 2, 2024
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene
force-pushed
the
NOISSUE-fixListUserInDomain
branch
from
c80870c to
1d2d84c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a bug fix because it fixes list domain user.
What does this do?
It fixes how
listMembersis implemented.Which issue(s) does this PR fix/relate to?
No issue.
Have you included tests for your changes?
Yes
Did you document any new/modified feature?
N/A
Notes