MG-2059 - Set correct log level depending on error #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyagamunene
force-pushed
the
MG2059-ErrorRefactoring
branch
2 times, most recently
from
533c151 to
a596fd9
Compare
arvindh123
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Please check the following files, I found some error are logged as Warn :
auth/api/logging.go L30 to L128 https://github.com/nyagamunene/magistrala/blob/a596fd9abbf62be732b9185855def1f492f3baeb/auth/api/logging.go#L37-L129
bootstrap/api/logging.go
bootstrap/postgres/configs.go
certs/api/logging.go
cmd/opcua/main.go
coap/api/transport.go
consumers/notifiers/api/logging.go
consumers/writers/api/logging.go
internal/groups/api/logging.go
consumers/writers/api/logging.go
internal/groups/api/logging.go
lora/api/logging.go
invitations/middleware/logging.go
opcua/api/logging.go
pkg/events/redis/subscriber.go
things/api/logging.go
twins/api/logging.go
users/api/logging.go
ws/api/endpoints.go
rodneyosodo
requested changes
May 3, 2024
There was a problem hiding this comment.
Some errors should be logged with Warn while others should be logged with Error. This is a simple explanation of how to do it https://stackoverflow.com/a/2031195 . Also, consider using ErrorContext and pass in the context rather than Error
nyagamunene
force-pushed
the
MG2059-ErrorRefactoring
branch
2 times, most recently
from
95f66c4 to
7022dd0
Compare
dborovcanin
force-pushed
the
MG2059-ErrorRefactoring
branch
from
7022dd0 to
a8be062
Compare
rodneyosodo
requested changes
May 17, 2024
auth/api/logging.go
Outdated
| @@ -34,7 +34,7 @@ func (lm *loggingMiddleware) ListObjects(ctx context.Context, pr auth.PolicyReq, | |||
| } | |||
| if err != nil { | |||
| args = append(args, slog.Any("error", err)) | |||
| lm.logger.Warn("List objects failed to complete successfully", args...) | |||
| lm.logger.ErrorContext(ctx, "List objects failed to complete successfully", args...) | |||
There was a problem hiding this comment.
Revert all errors to WarnContext
ws/api/endpoints.go
Outdated
| @@ -27,7 +27,7 @@ func handshake(ctx context.Context, svc ws.Service) http.HandlerFunc { | |||
| } | |||
| conn, err := upgrader.Upgrade(w, r, nil) | |||
| if err != nil { | |||
| logger.Warn(fmt.Sprintf("Failed to upgrade connection to websocket: %s", err.Error())) | |||
| logger.Error(fmt.Sprintf("Failed to upgrade connection to websocket: %s", err.Error())) | |||
ws/api/endpoints.go
Outdated
| @@ -62,7 +62,7 @@ func decodeRequest(r *http.Request) (connReq, error) { | |||
|
|
|||
| channelParts := channelPartRegExp.FindStringSubmatch(r.RequestURI) | |||
| if len(channelParts) < 2 { | |||
| logger.Warn("Empty channel id or malformed url") | |||
| logger.Error("Empty channel id or malformed url") | |||
arvindh123
force-pushed
the
MG2059-ErrorRefactoring
branch
from
a8be062 to
bdcbd75
Compare
nyagamunene
force-pushed
the
MG2059-ErrorRefactoring
branch
from
bdcbd75 to
567b80a
Compare
nyagamunene
changed the title
nyagamunene
force-pushed
the
MG2059-ErrorRefactoring
branch
from
8fb868f to
ac0a377
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
nyagamunene
force-pushed
the
MG2059-ErrorRefactoring
branch
from
7911b5b to
363c11d
Compare
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor because it sets correct log level depending on error.
What does this do?
It fixes the correct log level for the logs. Currently all log are warnings.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No.
Did you document any new/modified feature?
No.
Notes