Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NgbModalOptions Examples #20682

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Conversation

E-Aghbari
Copy link
Contributor

@E-Aghbari E-Aghbari commented Aug 29, 2024

Description

I have added two examples demonstrating two frequently used NgbModalOptions properties. Each example is accompanied by visual materials (GIFs/PNG) to clearly illustrate the effects of these properties in action. This update is intended to help developers understand how these properties can be utilised in their applications.
Resolves #18315 (write the related issue number if available)

TODO:

  • Added two new examples showcasing the usage of frequently used NgbModalOptions properties.
  • Included GIFs and PNGs for each example to visually demonstrate the modal behavior.
  • No breaking changes introduced.

Checklist

  • I fully tested it as developer / designer and created unit / integration tests
  • I documented it (or no need to document or I will create a separate documentation issue)

How to test it?

  • Navigate to the examples section in the documentation.
  • Observe the behavior of the modals when the two NgbModalOptions properties are applied.
  • Verify that the GIFs/PNGs correctly illustrate the modal’s behavior as described.

@CLAassistant
Copy link

CLAassistant commented Aug 29, 2024

CLA assistant check
All committers have signed the CLA.

@E-Aghbari E-Aghbari changed the title NgbModalOptions Examples - closes issue #18315 NgbModalOptions Examples Aug 29, 2024
@E-Aghbari
Copy link
Contributor Author

@masum-ulu i have created a PR. Could you please review it?
Thank you.

@masum-ulu
Copy link
Member

Hi @E-Aghbari, my teammate will review thanks for your contribution.

@E-Aghbari
Copy link
Contributor Author

@sumeyyeKurtulus could you review it please? thanks

@sumeyyeKurtulus sumeyyeKurtulus merged commit b86c3be into abpframework:dev Sep 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create examples for NgbModalOptions to Angular Modal document
4 participants