Skip to content
This repository has been archived by the owner on Jun 19, 2024. It is now read-only.

Upgrade to 2.11.0; update maintainer in manifest. #29

Open
wants to merge 1 commit into
base: testing
Choose a base branch
from

Conversation

jchammons
Copy link

Problem

  • Upgrade to latest release and update maintainer that will keep this current.

Solution

  • See PR.

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Package_check results


If you have access to App Continuous Integration for packagers you can provide a link to the package_check results like below, replacing '-NUM-' in this link by the PR number and USERNAME by your username on the ci-apps-dev. Or you provide a screenshot or a pastebin of the results

Build Status

Copy link
Member

@tituspijean tituspijean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmh, I really do not like how the versions are not really handled:

# scripts/install
version=$(curl -s https://api.github.com/repos/docker/compose/releases/latest | grep 'tag_name' | cut -d\" -f4)
portainer_version=$(curl -s https://api.github.com/repos/portainer/portainer/releases/latest | grep 'tag_name' | cut -d\" -f4)

This is asking for app failure if there is a breaking change upstream, either on Docker or Portainer. We should be able to set these versions in scripts/_common.sh and actively update them.

@fflorent
Copy link

fflorent commented Feb 4, 2022

BTW, docker-compose is available in the official Debian repository for Buster:
https://packages.debian.org/buster/docker-compose

Wouldn't it be simpler to use it instead?
I don't know if that would address the point raised by @tituspijean. I guess docker-compose should be retrocompatible while the major version remaings 1, so a dependency like docker-compose=1.* could do the trick.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants