lib: Add support for not returning PIN when using bio verification #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notdpate
requested changes
Aug 28, 2024
aveenismail
force-pushed
the
verify_bio
branch
from
9f77075
to
a772507
Compare
notdpate
requested changes
Aug 29, 2024
notdpate
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
This should work. If something horrible happens, I can change things around in the next ykmd release. I'd test this in as many scenarios as possible.
From what I understand, the piv tool is only ever going to use the "blank" verify for keyref 80 to check if piv is selected (which it does through ykpiv_verify_select(), but it's not an option that the user can force through actions and/or command line arguments.
For bio, it's going to use the 03 variant, which doesn't return the session pin, since it doesn't really need it. The code paths should allow ykmd to continue to use the 02 and 01 variants to get the session pin and verify the session pin.
aveenismail
force-pushed
the
verify_bio
branch
from
92f6eb7
to
ff0cbdc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.