Fix checking in_len when signing

Yubico · Jan 29, 2024 · e96e08f · e96e08f
1 parent 31d4580
commit e96e08f
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/lib/ykpiv.c b/lib/ykpiv.c
@@ -1228,8 +1228,6 @@ static ykpiv_rc _general_authenticate(ykpiv_state *state,
       }
       break;
     case YKPIV_ALGO_ECCP256:
-    case YKPIV_ALGO_ED25519:
-    case YKPIV_ALGO_X25519:
       key_len = 32;
       // fall through
     case YKPIV_ALGO_ECCP384:
@@ -1243,6 +1241,16 @@ static ykpiv_rc _general_authenticate(ykpiv_state *state,
 	      return YKPIV_SIZE_ERROR;
       }
       break;
+    case YKPIV_ALGO_X25519:
+      if(in_len != 32) {
+        return YKPIV_SIZE_ERROR;
+      }
+      break;
+    case YKPIV_ALGO_ED25519:
+      if(in_len > CB_BUF_MAX) {
+        return YKPIV_SIZE_ERROR;
+      }
+      break;
     default:
       return YKPIV_ALGORITHM_ERROR;
   }