Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement some style improvements #698

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Implement some style improvements #698

merged 4 commits into from
Sep 30, 2024

Conversation

benpueschel
Copy link
Contributor

  • Remove deprecated function calls in pr review tests, use the new functions
  • Break-up large first paragraphs in doc comments
  • Indent new lines on list elements in doc comments
  • Call assert!(result.is_err()) instead of assert!(!result.is_ok()) in user blocks tests
  • Implement Display trait instead of directly implementing ToString for PullRequestTarget

@benpueschel
test(pr_review): remove deprecated function calls
b903eec
@benpueschel
style(docs): fix indentation
f1c0c10 
Fix indentation and break-up large first paragraphs in doc comments.
@benpueschel
style: assert is_err() instead of !is_ok()
609da7e
@benpueschel
style: implement Display instead of ToString
b29bb3b 
Any Display implementation will automatically implement ToString, so
this change is not breaking.
@XAMPPRocky
Copy link
Owner

Thank you for your PR!

@XAMPPRocky XAMPPRocky merged commit 9fbf59c into XAMPPRocky:main Sep 30, 2024
11 checks passed
@github-actions github-actions bot mentioned this pull request Sep 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benpueschel @XAMPPRocky