-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Audio.MusicGetFilepath" and "Audio.MusicGetFilepathArguments" #72
Open
SolaceEllery
wants to merge
19
commits into
WohlSoft:master
Choose a base branch
from
SolaceEllery:music-slot-switching
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… support for getting the currently playing music and SFX
…tart on events for SFXs (onSFXStart)
… system though...
… function anyway...
SolaceEllery
changed the title
Music ID overriding (Audio.sounds equalivent)
Music ID related things + Audio.MusicGet()
Jan 30, 2024
…hange "Audio.MusicGet()" to "Audio.MusicGetFilepath()", and add support for getting the music filepath when sections are seized
SolaceEllery
changed the title
Music ID related things + Audio.MusicGet()
Add "Audio.MusicGetFilepath()"
Jun 22, 2024
…playing SDL Mixer X arguments, and have a boolean argument for "Audio.MusicGetFilepath", that if true, will keep the arguments intact (False to remove them)
SolaceEllery
changed the title
Add "Audio.MusicGetFilepath()"
Add "Audio.MusicGetFilepath" and "Audio.MusicGetFilepathArguments"
Jun 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, I made a pull request with new functions added: "Audio.MusicGetFilepath" and "Audio.MusicGetFilepathArguments"!
With the functions, you can now see what music is currently playing on the engine, along with getting the SDL Mixer X arguments at the end! The functions should support all of these instances:
Here's the function information below:
Hope this pull request gets accepted!