parse OTP 26 feature attribute

Summary: As title. We lower it as part of the `FormList`, but not in HIR. Note: ELP support for parsing `maybe` is always enabled, regardless of the feature flag. Reviewed By: perehonchuk Differential Revision: D49950781 fbshipit-source-id: ee2869e33203a8ffc6649b904513c982ece792f7
WhatsApp · Oct 5, 2023 · f66f7cd · f66f7cd
1 parent 4a0ec79
commit f66f7cd
Show file tree

Hide file tree

Showing 5 changed files with 24,486 additions and 23,960 deletions.
diff --git a/grammar.js b/grammar.js
@@ -145,6 +145,7 @@ module.exports = grammar({
             $.export_type_attribute,
             $.optional_callbacks_attribute,
             $.compile_options_attribute,
+            $.feature_attribute,
             $.file_attribute,
             $.deprecated_attribute,
             $.record_decl,
@@ -279,6 +280,14 @@ module.exports = grammar({
             '.'
         ),
 
+        feature_attribute: $ => seq(
+            '-',
+            atom_const('feature'),
+            '(',
+            field("feature", $._expr), ',',
+            field("flag", $._expr),
+            ')', '.'),
+
         _deprecated_details: $ => choice(
             $.deprecated_module,
             $.deprecated_fa,

diff --git a/src/grammar.json b/src/grammar.json
@@ -44,6 +44,10 @@
           "type": "SYMBOL",
           "name": "compile_options_attribute"
         },
+        {
+          "type": "SYMBOL",
+          "name": "feature_attribute"
+        },
         {
           "type": "SYMBOL",
           "name": "file_attribute"
@@ -1279,6 +1283,65 @@
         }
       ]
     },
+    "feature_attribute": {
+      "type": "SEQ",
+      "members": [
+        {
+          "type": "STRING",
+          "value": "-"
+        },
+        {
+          "type": "CHOICE",
+          "members": [
+            {
+              "type": "STRING",
+              "value": "feature"
+            },
+            {
+              "type": "ALIAS",
+              "content": {
+                "type": "STRING",
+                "value": "'feature'"
+              },
+              "named": false,
+              "value": "feature"
+            }
+          ]
+        },
+        {
+          "type": "STRING",
+          "value": "("
+        },
+        {
+          "type": "FIELD",
+          "name": "feature",
+          "content": {
+            "type": "SYMBOL",
+            "name": "_expr"
+          }
+        },
+        {
+          "type": "STRING",
+          "value": ","
+        },
+        {
+          "type": "FIELD",
+          "name": "flag",
+          "content": {
+            "type": "SYMBOL",
+            "name": "_expr"
+          }
+        },
+        {
+          "type": "STRING",
+          "value": ")"
+        },
+        {
+          "type": "STRING",
+          "value": "."
+        }
+      ]
+    },
     "_deprecated_details": {
       "type": "CHOICE",
       "members": [

diff --git a/src/node-types.json b/src/node-types.json
@@ -381,6 +381,10 @@
         "type": "export_type_attribute",
         "named": true
       },
+      {
+        "type": "feature_attribute",
+        "named": true
+      },
       {
         "type": "file_attribute",
         "named": true
@@ -1431,6 +1435,32 @@
       }
     }
   },
+  {
+    "type": "feature_attribute",
+    "named": true,
+    "fields": {
+      "feature": {
+        "multiple": false,
+        "required": true,
+        "types": [
+          {
+            "type": "_expr",
+            "named": true
+          }
+        ]
+      },
+      "flag": {
+        "multiple": false,
+        "required": true,
+        "types": [
+          {
+            "type": "_expr",
+            "named": true
+          }
+        ]
+      }
+    }
+  },
   {
     "type": "field_expr",
     "named": true,
@@ -3409,6 +3439,10 @@
     "type": "export_type",
     "named": false
   },
+  {
+    "type": "feature",
+    "named": false
+  },
   {
     "type": "file",
     "named": false