Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read input only once #346

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jdamanalo
Copy link

@jdamanalo jdamanalo commented Jan 12, 2023

Close #238

Time

time for i in {1..5}; _build/release/bin/erlfmt -w 'otp/lib/*/{src,include}/*.{erl,hrl}'; done

Main
real 0m43.746s
user 1m51.063s
sys 0m39.859s

This
real 0m36.764s
user 1m35.922s
sys 0m34.750s

Potential incompatibility

Changed return of format_[file, file_range, string_full, string_range] to include the original. Type of formatted string from [unicode:chardata()] to string().

Possible alternative: Introduce new tag unchanged.

Question

Can format_file_range be removed?

- Unified entry point to string formatting
@facebook-github-bot
Copy link

Hi @jdamanalo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 12, 2023
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read file only once
2 participants