Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(component): move key_filter validation to the model #12664

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix(component): move key_filter validation to the model #12664

merged 1 commit into from
Oct 3, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 3, 2024 •
edited
Loading

Proposed changes

  • This needs to be on the model to validate edits via API.
  • Fix test to actually test for validation error.
  • Remove not needed r prefix from some strings.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel
fix(component): move key_filter validation to the model
8784599 
- This needs to be on the model to validate edits via API.
- Fix test to actually test for validation error.
- Remove not needed r prefix from some strings.
@nijel nijel added this to the 5.8 milestone Oct 3, 2024
@nijel nijel requested a review from harriebird October 3, 2024 06:07
@nijel nijel self-assigned this Oct 3, 2024
@nijel nijel enabled auto-merge (rebase) October 3, 2024 06:07
@nijel nijel merged commit c7a51cb into WeblateOrg:main Oct 3, 2024
33 of 34 checks passed
@nijel nijel deleted the key-filter-validate branch October 3, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harriebird harriebird Awaiting requested review from harriebird

Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.
1 participant
@nijel