Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(search): lazily import dateparser #12655

Merged
merged 1 commit into from
Oct 2, 2024
Merged

feat(search): lazily import dateparser #12655

merged 1 commit into from
Oct 2, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Oct 2, 2024

Proposed changes

It can be expensive to import due to building thousands of regexps at import time (see scrapinghub/dateparser#1181).

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel
feat(search): lazily import dateparser
bf9ff64 
It can be expensive to import due to building thousands of regexps at
import time (see scrapinghub/dateparser#1181).
@nijel nijel added this to the 5.8 milestone Oct 2, 2024
@nijel nijel requested a review from harriebird October 2, 2024 09:42
@nijel nijel self-assigned this Oct 2, 2024
@nijel nijel enabled auto-merge (rebase) October 2, 2024 09:42
@nijel nijel merged commit 404a3c1 into WeblateOrg:main Oct 2, 2024
34 checks passed
@nijel nijel deleted the dateparser-lazy branch October 2, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harriebird harriebird Awaiting requested review from harriebird

Assignees

@nijel nijel

Labels
None yet
Projects
None yet
Milestone
5.8
Development

Successfully merging this pull request may close these issues.
1 participant
@nijel