Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(formats): avoid CSV autodetection for generated CSV files from Excel #11885

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Jun 18, 2024

Proposed changes

Depends on translate/translate#5267

Fixes #11872

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel self-assigned this Jun 18, 2024
@nijel nijel added this to the 5.6 milestone Jun 18, 2024
@nijel nijel marked this pull request as ready for review June 18, 2024 08:39
@nijel nijel enabled auto-merge (rebase) June 18, 2024 08:39
@nijel nijel disabled auto-merge June 18, 2024 11:01
@nijel nijel merged commit 36ff3de into WeblateOrg:main Jun 18, 2024
28 of 29 checks passed
@nijel nijel deleted the excel-detect branch June 18, 2024 11:01
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.60%. Comparing base (6aee586) to head (a51ff42).
Report is 3978 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11885      +/-   ##
==========================================
- Coverage   90.82%   90.60%   -0.22%     
==========================================
  Files         554      576      +22     
  Lines       57306    58777    +1471     
  Branches     9122     9383     +261     
==========================================
+ Hits        52046    53254    +1208     
- Misses       3640     3829     +189     
- Partials     1620     1694      +74     
Files with missing lines Coverage Δ
weblate/formats/external.py 88.37% <100.00%> (-2.81%) ⬇️
weblate/formats/ttkit.py 90.84% <100.00%> (-0.57%) ⬇️

... and 326 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excel File Translation Upload Error
1 participant