Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): use template tags to render numbers and percent in lists #11531

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

nijel
Copy link
Member

@nijel nijel commented Apr 30, 2024

Proposed changes

This removes additional overhead of rendering each value as separate template reducing rendering time of larger lists to 50%.

Checklist

  • Lint and unit tests pass locally with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added documentation to describe my feature.
  • I have squashed my commits into logic units.
  • I have described the changes in the commit messages.

Other information

@nijel nijel self-assigned this Apr 30, 2024
@nijel nijel enabled auto-merge (rebase) April 30, 2024 06:55
@nijel nijel added this to the 5.5.3 milestone Apr 30, 2024
nijel added a commit that referenced this pull request Apr 30, 2024
…ists

This removes additional overhead of rendering each value as separate
template reducing rendering time of larger lists to 50%.
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.50%. Comparing base (6aee586) to head (fe9bf8a).
Report is 1548 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #11531      +/-   ##
==========================================
- Coverage   90.82%   90.50%   -0.32%     
==========================================
  Files         554      570      +16     
  Lines       57306    58528    +1222     
  Branches     9122     9358     +236     
==========================================
+ Hits        52046    52969     +923     
- Misses       3640     3854     +214     
- Partials     1620     1705      +85     
Files Coverage Δ
weblate/trans/templatetags/translations.py 89.51% <100.00%> (+0.30%) ⬆️

... and 241 files with indirect coverage changes

@nijel nijel merged commit 5141a83 into WeblateOrg:main Apr 30, 2024
29 of 31 checks passed
@nijel nijel deleted the list-object branch April 30, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant