widgets: add PNG status badge #11466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is SVG rendered into PNG using rsvg, which is already pulled as a dependency for Pango/Cairo stack. Fixes WeblateOrg#6221
|
@nijel after this change, I get tons of error reports because Weblate throws errors when trying to get the PNG status badge: seems like that |
nijel
added a commit
that referenced
this pull request
Apr 30, 2024
The render_document is new feature in 2.46, before there was render_cairo which is now deprecated. See #11466
|
Ah, this interface was added in librsvg 2.46 (see https://lazka.github.io/pgi-docs/Rsvg-2.0/classes/Handle.html#Rsvg.Handle.render_document), so you probably have an older version. I've adjusted the required version in e58b409. |
|
53994d9 should make it work with older versions as well. |
nijel
added a commit
that referenced
this pull request
Apr 30, 2024
|
That worked - thanks for the quick help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
It is SVG rendered into PNG using rsvg, which is already pulled as a dependency for Pango/Cairo stack.
Fixes #6221
Checklist
Other information