Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model picker search with multiple words #5410

Closed
wants to merge 2 commits into from

Conversation

walruscow
Copy link

@walruscow walruscow commented Sep 13, 2024

Description

This change allows multiple filters to be applied in model picker search, by separating on spaces.

Before, it was difficult to find specific things like "warlock fel effects" or "runes with multiple pieces". Now, these filters can be accomplished by e.g. searching "warlock fel" or "rune 0". In my experience, this makes it a lot easier to find models I'm interested in.

  • The filter string is split on space to form a filter list
    • This is safe because no model paths include a space today
  • Must match all filters in the list
  • Only create the filter list once

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Searched in the model picker without spaces
  • Searched in the model picker with spaces
  • Paid attention to the search speed, it seems similar to before

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshot

image

@InfusOnWoW
Copy link
Contributor

We recently added some more advanced filtering to the aura search: 7569c2f That adds "|" and " or " as or filters.

Your change adds "and" filtering which conflicts with what we just added to the general aura search.

These two searches shouldn't behave in widely different ways.

@walruscow walruscow closed this Sep 14, 2024
@walruscow
Copy link
Author

That's ok, feel free to take/change it as you like or not :)

@Stanzilla
Copy link
Contributor

That's ok, feel free to take/change it as you like or not :)

Thank you!

@walruscow walruscow deleted the model-picker-search branch September 15, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants