Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pokemon Notifications #343

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Pokemon Notifications #343

wants to merge 7 commits into from

Conversation

versx
Copy link
Collaborator

@versx versx commented Mar 16, 2021

Add pokemon notifications based on exiting map filters. Selecting a notification will center the map on the specific pokemons location. Also toggle-able via the Settings page under the pokemon section.

TODO: Play notification sound (eventually specific pokemon cries possibly)

image

image

@versx versx requested review from a team, bschultz, clburlison, TurtIeSocks, Lutacon, lenisko and Shyvadi and removed request for a team March 26, 2021 23:56
Copy link
Contributor

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notifications pop up for everything on the map on the initial page load, which drastically reduces loading times for new areas.

For example, if view A contains views B & C. If I start at view B, then zoom out to view A, it cycles through tons and tons of notifications before even thinking about loading the markers in view C. To the point where I have to zoom in to view C, to get things to load.

Suggestion: only have notifications for new Pokemon that load in after the page has already been rendered, not for every single Pokemon that was already there and is just loading in for the first time.

Suggestion: Make the notifications slightly smaller.

It also made navigating menus a little rough as they kept blocking the view, but this behavior may be solved with my first suggestion.

I was using gl1-3 | ul1-3 | 90-100 for testing. I realize refining the filters will reduce the number of notifications, but then again, if the filters are refined to something like gl1-3 | ul1-3 | 100 are the notifications really providing that much value when it's pretty easy to see every spawn of interest on the map anyway?

I don't know anything about showing # of notifications in the browser tab itself, but that could be pretty helpful if it's possible to implement.

Great work overall!

@versx
Copy link
Collaborator Author

versx commented Apr 9, 2021

Notifications pop up for everything on the map on the initial page load, which drastically reduces loading times for new areas.

For example, if view A contains views B & C. If I start at view B, then zoom out to view A, it cycles through tons and tons of notifications before even thinking about loading the markers in view C. To the point where I have to zoom in to view C, to get things to load.

Suggestion: only have notifications for new Pokemon that load in after the page has already been rendered, not for every single Pokemon that was already there and is just loading in for the first time.

Suggestion: Make the notifications slightly smaller.

It also made navigating menus a little rough as they kept blocking the view, but this behavior may be solved with my first suggestion.

I was using gl1-3 | ul1-3 | 90-100 for testing. I realize refining the filters will reduce the number of notifications, but then again, if the filters are refined to something like gl1-3 | ul1-3 | 100 are the notifications really providing that much value when it's pretty easy to see every spawn of interest on the map anyway?

I don't know anything about showing # of notifications in the browser tab itself, but that could be pretty helpful if it's possible to implement.

Great work overall!

Yeah I didn't put too much logic on when they should show tbh other than coming in from the api request. Thanks for the suggestion, I'll add an if statement to ignore if the map isn't loaded yet so only new spawns are shown after rendering of initial page load is complete.

@versx
Copy link
Collaborator Author

versx commented Apr 9, 2021

Think it's worth adding PVP stats to the notifications if available? It would likely cause the notifications to be at least 2 different sizes, so might be bad UX, idk lol.

@lenisko
Copy link
Contributor

lenisko commented Apr 9, 2021

@versx with ability to toggle PvP addition in settings... I can see only a benefits :)

@versx
Copy link
Collaborator Author

versx commented Apr 16, 2021

@versx with ability to toggle PvP addition in settings... I can see only a benefits :)

Good point 😄

Copy link
Contributor

@TurtIeSocks TurtIeSocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing notifications for all upon initial render 🤔

Also needs an i18n entry for the new setting to toggle notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants