Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Theming Support #224

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Custom Theming Support #224

wants to merge 7 commits into from

Conversation

versx
Copy link
Collaborator

@versx versx commented Sep 24, 2020

Better implementation of #218 to allow you to create beautiful and elegant themes like the following:
Omg: (originally named Mygod 😉)

TODO:

  • Remove server side theme option

image

Default:
image

Blue:
image

Dark:
image

Light:
image

Green:
image

@versx versx changed the title Add custom themes Custom Theming Support Sep 24, 2020
Copy link
Contributor

@clburlison clburlison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile support 🙂😅

image

@versx
Copy link
Collaborator Author

versx commented Sep 24, 2020

Mobile support 🙂😅

image

Oof, thanks

Copy link
Contributor

@clburlison clburlison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Mygod Mygod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now whenever I write a new style I need to write it in five different css.example too or check that they work correctly for all five example themes and pray that it does not break some custom themes? What a terrible idea. No thanks.

@versx
Copy link
Collaborator Author

versx commented Sep 26, 2020

So now whenever I write a new style I need to write it in five different css.example too or check that they work correctly for all five example themes and pray that it does not break some custom themes? What a terrible idea. No thanks.

You write it for that one theme...

@Mygod
Copy link
Contributor

Mygod commented Sep 26, 2020

As I said you still need to test them all. Not very excited.

@versx versx added the enhancement New feature or request label Sep 27, 2020
@versx
Copy link
Collaborator Author

versx commented Mar 11, 2021

Anyone have any suggestions for improving this so @Mygod doesn't have to update each template when there's changes?

@Mygod
Copy link
Contributor

Mygod commented Mar 11, 2021

Maybe have some guidelines for contributing, so that everyone knows how to add a UI element that will be consistent with themes?

@versx
Copy link
Collaborator Author

versx commented Mar 11, 2021

Maybe have some guidelines for contributing, so that everyone knows how to add a UI element that will be consistent with themes?

Thanks, that's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants