Update explainer #26
Merged
Update explainer #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build fails on a file that isn't changed. I created speced/bikeshed#2732. |
|
Thanks @backkem for updating the explainer and making the API consistent between the explainer and the cg-draft of the spec. Subsequent API updates will be gradually improved, LGTM. |
anssiko
approved these changes
Dec 11, 2023
Co-authored-by: Anssi Kostiainen <[email protected]>
|
This all LGTM! Great updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a suggested update to the explainer to be more in line with the current version of the spec document and to remove some duplicate work (mainly the initial API proposal).
@ibelem I would love your review since you created the original explainer.
@getify please let me know if you feel this sufficiently addresses #20.
Preview | Diff